fix(cli-hooks): use correct bolt-js release notes tag format#2602
fix(cli-hooks): use correct bolt-js release notes tag format#2602zimeg wants to merge 5 commits into
Conversation
The bolt-js repository changed its release tag format from `@slack/bolt@x.y.z` to `vx.y.z`. Update the release notes URL to match the new tag convention. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
🦋 Changeset detectedLatest commit: 7d1d667 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
zimeg
left a comment
There was a problem hiding this comment.
🗣️ A note for wonderful reviewers!
| function getReleaseNotesUrl(packageName, latestVersion) { | ||
| if (packageName === SLACK_BOLT_SDK) { | ||
| return `https://github.com/slackapi/bolt-js/releases/tag/@slack/bolt@${latestVersion}`; | ||
| return `https://github.com/slackapi/bolt-js/releases/tag/v${latestVersion}`; |
There was a problem hiding this comment.
🚀 note: Our latest releases now keep a shortened tag. IMHO we can ignore earlier formatting unless this changes again since release notifications appear with latest versions and not prior updates?
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Looks good to me! I prefer the new release format as well.
Summary
This pull request fixes the release notes URL for
@slack/boltin the check-update hook. The bolt-js repository changed its release tag format from@slack/bolt@x.y.ztovx.y.z, so the generated URL was pointing to non-existent release pages.Requirements