Skip to content

fix(cli-hooks): use correct bolt-js release notes tag format#2602

Open
zimeg wants to merge 5 commits into
mainfrom
zimeg-fix-cli-hooks-bolt-release-tag
Open

fix(cli-hooks): use correct bolt-js release notes tag format#2602
zimeg wants to merge 5 commits into
mainfrom
zimeg-fix-cli-hooks-bolt-release-tag

Conversation

@zimeg
Copy link
Copy Markdown
Member

@zimeg zimeg commented May 20, 2026

Summary

This pull request fixes the release notes URL for @slack/bolt in the check-update hook. The bolt-js repository changed its release tag format from @slack/bolt@x.y.z to vx.y.z, so the generated URL was pointing to non-existent release pages.

Requirements

The bolt-js repository changed its release tag format from
`@slack/bolt@x.y.z` to `vx.y.z`. Update the release notes URL
to match the new tag convention.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 20, 2026

🦋 Changeset detected

Latest commit: 7d1d667

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@slack/cli-hooks Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@zimeg zimeg self-assigned this May 20, 2026
@zimeg zimeg added this to the cli-hooks@next milestone May 20, 2026
@zimeg zimeg added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented pkg:cli-hooks applies to `@slack/cli-hooks` labels May 20, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
387 1 386 0
View the top 1 failed test(s) by shortest run time
test::shows version information for packages
Stack Traces | 0.012s run time
Error [ERR_TEST_FAILURE]: Expected values to be loosely deep-equal:

{
  error: undefined,
  message: '',
  name: 'the Slack SDK',
  releases: [
    {
      breaking: false,
      current: '3.0.0',
      error: undefined,
      latest: '3.1.4',
      message: undefined,
      name: '@slack/bolt',
      update: true,
      url: 'https://github..../releases/tag/v3.1.4'
    },
    {
      breaking: true,
      current: '0.0.1',
      error: undefined,
      latest: '1.0.1',
      message: undefined,
      name: '@slack/cli-hooks',
      update: true,
      u...

should loosely deep-equal

{
  error: undefined,
  message: '',
  name: 'the Slack SDK',
  releases: [
    {
      breaking: false,
      current: '4.0.0',
      error: undefined,
      latest: '4.7.2',
      message: undefined,
      name: '@slack/bolt',
      update: true,
      url: 'https://github..../releases/tag/v4.7.2'
    },
    {
      breaking: true,
      current: '0.0.1',
      error: undefined,
      latest: '1.0.1',
      message: undefined,
      name: '@slack/cli-hooks',
      update: true,
      u...
    at async Promise.all (index 0)
    at async Promise.all (index 0) {
  code: 'ERR_TEST_FAILURE',
  failureType: 'testCodeFailure',
  cause: AssertionError [ERR_ASSERTION]: Expected values to be loosely deep-equal:
  
  {
    error: undefined,
    message: '',
    name: 'the Slack SDK',
    releases: [
      {
        breaking: false,
        current: '3.0.0',
        error: undefined,
        latest: '3.1.4',
        message: undefined,
        name: '@slack/bolt',
        update: true,
        url: 'https://github..../releases/tag/v3.1.4'
      },
      {
        breaking: true,
        current: '0.0.1',
        error: undefined,
        latest: '1.0.1',
        message: undefined,
        name: '@slack/cli-hooks',
        update: true,
        u...
  
  should loosely deep-equal
  
  {
    error: undefined,
    message: '',
    name: 'the Slack SDK',
    releases: [
      {
        breaking: false,
        current: '4.0.0',
        error: undefined,
        latest: '4.7.2',
        message: undefined,
        name: '@slack/bolt',
        update: true,
        url: 'https://github..../releases/tag/v4.7.2'
      },
      {
        breaking: true,
        current: '0.0.1',
        error: undefined,
        latest: '1.0.1',
        message: undefined,
        name: '@slack/cli-hooks',
        update: true,
        u...
      at TestContext.<anonymous> (file:///D:.../cli-hooks/src/check-update.test.js:96:14)
      at async Test.run (node:internal/test_runner/test:797:9)
      at async Promise.all (index 0)
      at async Suite.run (node:internal/test_runner/test:1135:7)
      at async Promise.all (index 0)
      at async Suite.run (node:internal/test_runner/test:1135:7)
      at async Test.processPendingSubtests (node:internal/test_runner/test:526:7) {
    generatedMessage: true,
    code: 'ERR_ASSERTION',
    actual: { name: 'the Slack SDK', message: '', releases: [Array], url: 'https://docs.slack.dev/changelog', error: undefined },
    expected: { name: 'the Slack SDK', error: undefined, message: '', releases: [Array], url: 'https://docs.slack.dev/changelog' },
    operator: 'deepEqual'
  }
}

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Copy Markdown
Member Author

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗣️ A note for wonderful reviewers!

function getReleaseNotesUrl(packageName, latestVersion) {
if (packageName === SLACK_BOLT_SDK) {
return `https://github.com/slackapi/bolt-js/releases/tag/@slack/bolt@${latestVersion}`;
return `https://github.com/slackapi/bolt-js/releases/tag/v${latestVersion}`;
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 note: Our latest releases now keep a shortened tag. IMHO we can ignore earlier formatting unless this changes again since release notifications appear with latest versions and not prior updates?

📚 https://github.com/slackapi/bolt-js/releases/tag/v4.7.2

@zimeg zimeg marked this pull request as ready for review May 20, 2026 00:12
@zimeg zimeg requested a review from a team as a code owner May 20, 2026 00:12
Copy link
Copy Markdown
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Looks good to me! I prefer the new release format as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented pkg:cli-hooks applies to `@slack/cli-hooks` semver:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants