Skip to content

fix(home): defer unopened post carousels #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harlan-zw merged 1 commit into from
Oct 14, 2026
Merged

fix(home): defer unopened post carousels #654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/pages/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ function recentRepoDescription(item: RecentRepoUpdate): string {
<div class="mt-8">
<ol class="editorial-ledger list-none p-0">
<li v-for="{ row, rank } in homeTrendingRows" :key="row.key">
<LazyTrendingBoardItem hydrate-on-visible :row :rank surface="home-trending-row" @avatar-error="onAvatarError" />
<LazyTrendingBoardItem hydrate-on-visible :row :rank defer-posts surface="home-trending-row" @avatar-error="onAvatarError" />
</li>
</ol>
</div>
Expand Down
13 changes: 9 additions & 4 deletions layers/marketing/app/components/TrendingBoardItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,14 @@ import TrendingStarSpark from './TrendingStarSpark.vue'
* one; the faces open every post. The posts used to show as a card under
* every row and tripled its height.
*/
const { row, rank, surface = 'trending-row' } = defineProps<{
const { row, rank, surface = 'trending-row', deferPosts = false } = defineProps<{
row: TrendingBoardRow
/** One-based position on the board. */
rank: number
/** Analytics surface for the run pill. */
surface?: string
/** Homepage previews mount the post carousel only when first opened. */
deferPosts?: boolean
}>()

const emit = defineEmits<{
Expand Down Expand Up @@ -62,7 +64,9 @@ const starLine = computed(() => row.reason._tag !== 'posts' && row.starSeries.le
*/
const hasReason = computed(() => row.reason._tag !== 'member' || starLine.value)

const open = ref(false)
const postsState = ref<'unopened' | 'open' | 'closed'>('unopened')
const open = computed(() => postsState.value === 'open')
const renderPosts = computed(() => !deferPosts || postsState.value !== 'unopened')
const postsId = useId()
const postsLabel = computed(() => `${posts.value.length} ${posts.value.length === 1 ? 'post' : 'posts'} about /${row.name}`)
</script>
Expand All @@ -82,7 +86,7 @@ const postsLabel = computed(() => `${posts.value.length} ${posts.value.length ==
</template>
<template v-if="hasReason" #meta>
<template v-if="posts.length">
<TrendingPostFaces :posts :open :controls="postsId" :label="postsLabel" @toggle="() => { open = !open }" />
<TrendingPostFaces :posts :open :controls="postsId" :label="postsLabel" @toggle="() => { postsState = open ? 'closed' : 'open' }" />
<!-- The first card repeats this post, so the line steps aside while the cards show. -->
<TrendingPostQuote v-if="!open" :post="posts[0]!" :names="row.names" />
</template>
Expand All @@ -103,10 +107,11 @@ const postsLabel = computed(() => `${posts.value.length} ${posts.value.length ==
<span v-else-if="row.reason._tag === 'filler'">Ranked by GitHub stars</span>
</template>
</template>
<!-- In the server HTML while closed, so every post the board ranked on stays readable to a crawler. -->
<!-- Full boards serialize their source posts. Homepage previews defer the carousel until first opened. -->
<template v-if="posts.length" #aside>
<div :id="postsId" :hidden="!open">
<TrendingPostCarousel
v-if="renderPosts"
:posts="posts"
:names="row.names"
:label="`Posts about /${row.name}`"
Expand Down
Loading