Fix manual pageview collection setting - #42
Merged
adriaandotcom merged 2 commits intoSep 15, 2026
Merged
Conversation
adriaandotcom
approved these changes
Sep 15, 2026
adriaandotcom
pushed a commit
that referenced
this pull request
Sep 15, 2026
## Summary Fixes #38 Run the configured callback through the script's onload handler instead of the unused data-onload attribute. WordPress escapes the handler, and the browser regression verifies execution with quoted callback text. Only users with unfiltered_html can authorize callback code. A site-specific signature records authorized saves. Previously stored callbacks remain inactive until an authorized administrator saves the Advanced settings again; changing WordPress authentication salts also requires saving again. Resolved the requested conflicts against current main. The merged version retains the manual-pageview fix from #42, both-state event-setting tests from #43, and the existing regression harness and lifecycle fixes. Manual collection still emits data-auto-collect="false", while the callback is supplied by OnloadCallback::get(). ## Testing - WordPress 7.1 / PHP 8.3.33: all 19 browser tests and all 3 WordPress regression tests passed. - Tests cover both manual-collection states, actual callback execution, authorized and rejected saves, inactive legacy or modified callback values, clearing the handler, IP sanitization, and plugin deactivation/uninstall behavior. - Frozen-lockfile install, asset build, PHP syntax, and diff checks passed. Co-authored-by: simple-analytics-ai[bot] <313929673+simple-analytics-ai[bot]@users.noreply.github.com> Co-authored-by: Simple Analytics Codex <codex@simpleanalytics.invalid>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking Manually collect page views now emits
data-auto-collect="false", disabling automatic pageviews as documented. Unchecking it restores the default automatic mode.Fixes #37.
Validation: the focused WordPress browser test failed on the original code (
trueinstead offalse) and passes with the fix, covering both checkbox states. PHP syntax and diff checks pass.Combined validation: all six proposed fixes were applied to a local integration branch; all 23 browser and WordPress regression tests, the asset build, PHP syntax checks and diff checks passed. GitHub workflows currently report
action_requiredfor these fork pull requests.