Skip to content

Execute the configured analytics load callback safely - #47

Merged
adriaandotcom merged 3 commits into
simpleanalytics:mainfrom
jdevalk:codex/fix-onload-callback
Sep 15, 2026
Merged

adriaandotcom merged 3 commits into
simpleanalytics:mainfrom
jdevalk:codex/fix-onload-callback

Conversation

@jdevalk

@jdevalk jdevalk commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #38

Run the configured callback through the script's onload handler instead of the unused data-onload attribute. WordPress escapes the handler, and the browser regression verifies execution with quoted callback text.

Only users with unfiltered_html can authorize callback code. A site-specific signature records authorized saves. Previously stored callbacks remain inactive until an authorized administrator saves the Advanced settings again; changing WordPress authentication salts also requires saving again.

Resolved the requested conflicts against current main. The merged version retains the manual-pageview fix from #42, both-state event-setting tests from #43, and the existing regression harness and lifecycle fixes. Manual collection still emits data-auto-collect="false", while the callback is supplied by OnloadCallback::get().

Testing

  • WordPress 7.1 / PHP 8.3.33: all 19 browser tests and all 3 WordPress regression tests passed.
  • Tests cover both manual-collection states, actual callback execution, authorized and rejected saves, inactive legacy or modified callback values, clearing the handler, IP sanitization, and plugin deactivation/uninstall behavior.
  • Frozen-lockfile install, asset build, PHP syntax, and diff checks passed.

jdevalk and others added 3 commits September 15, 2026 17:03
Resolve PR simpleanalytics#47 conflicts as requested, retaining the merged manual-pageview and automated-event fixes alongside the onload callback and all regression tests. Validated on WordPress 7.1 / PHP 8.3.33: 22 tests passed.
@adriaandotcom
adriaandotcom merged commit e76c39f into simpleanalytics:main Sep 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The configured Onload Callback never executes

2 participants