Skip to content

release: 0.46.1 #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arbianst merged 1 commit into from
Oct 30, 2026
Merged

release: 0.46.1 #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .release-please-manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
".": "0.46.0"
".": "0.46.1"
}
9 changes: 9 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# Changelog

## [0.46.1](https://github.com/sentdm/sent-dm-java/compare/v0.46.0...v0.46.1) (2026-10-30)


### Chores

* **repo:** add the contributor contract and review rubric ([373021e](https://github.com/sentdm/sent-dm-java/commit/373021e7e009906672ae32ea19c1c27e158ff10b))
* **repo:** add the contributor contract and the review workflow ([d8b5e53](https://github.com/sentdm/sent-dm-java/commit/d8b5e535e32b70a61b140ecf46f181d7c712552a))
Comment on lines +7 to +9

@claude claude Bot Oct 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 (optional) Customers reading the 0.46.1 notes get one change listed three times, including a workflow that is "added" and then "dropped" in the same release. Line 7 links merge commit 373021e, whose body repeats the subject of PR #8. Lines 8 and 9 are the two commits that PR merged, d8b5e53 and 9a83386. Fix: give one changed thing one customer-facing line, and drop the add-then-remove workflow pair, which never shipped. For example, use a release-please BEGIN_COMMIT_OVERRIDE on 373021e, or edit the release PR notes. Squash-merging PRs with conventional subjects prevents this happening again.

Why this was flagged

The trigger is merging this release PR. Release-please parsed both the merge commit 373021e (body "chore(repo): add the contributor contract and review rubric", parents 89134db and 9a83386) and the two commits it brought in. Commit d8b5e53 adds .github/workflows/claude-pr-review.yml, and 9a83386 deletes it, so on net no workflow reaches main. CHANGELOG.md:7-9 and the GitHub release notes therefore list the CLAUDE.md/REVIEW.md/CODEOWNERS addition twice. They also announce a workflow added and a workflow dropped, which cancel each other out. The 0.46.0 section has no such duplicates. CLAUDE.md says "The subject becomes the changelog line customers read, so write it for them". Release-please does not dedupe a merge-commit body against the commits it merges.

Verification: Nit. Triggered when this release PR is merged and the 0.46.1 notes are published. Merge commit 373021e's body is parsed as its own entry at CHANGELOG.md:7, repeating d8b5e53 (line 8). d8b5e53 adds .github/workflows/claude-pr-review.yml (+49) and 9a83386 (line 9) deletes it (-49), so no workflow ever reaches main.

* **repo:** rely on the managed Claude Code Review, drop the workflow ([9a83386](https://github.com/sentdm/sent-dm-java/commit/9a83386e0e37e29f8d43992ef738711b658745ae))
Comment on lines +4 to +10

@claude claude Bot Oct 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Merging this publishes 0.46.1 to Maven Central with no change customers can see. Its release notes describe only internal repo tooling. All three entries are chore(repo) commits adding contributor and review files, a type that cuts a release for an invisible change. One line also names an internal review vendor, "the managed Claude Code Review". Fix: hold this release PR until a customer-facing change lands, and drop or retitle the three repo-only lines (e.g. as ci:, which is hidden) so no published note names internal tooling.

Why this was flagged

The trigger is a maintainer merging this release PR. CLAUDE.md says "Merging the release PR publishes." The 0.46.1 section in CHANGELOG.md:4-10 lists only three chore(repo) commits: 373021e, d8b5e53 and 9a83386. They add or remove the contributor contract, the review rubric and the review workflow. The diff bumps build.gradle.kts:11 and README.md to 0.46.1, but the SDK code is the same as 0.46.0. Customers therefore get a new Maven Central artifact and javadoc build with no behaviour change. Their release notes describe internal process, and the line at CHANGELOG.md:10 names an internal review tool. REVIEW.md lists "a type that cuts a release for a change customers don't see" and an internal cause as Important. CLAUDE.md says changelog subjects must be written for customers, "Never an internal cause", and that nothing in CHANGELOG.md may name Sent's internal systems or providers. On the base branch, 0.46.0 stays the latest release and these lines are never published.

Verification: The trigger is a maintainer merging this release PR. CLAUDE.md:54 says "Merging the release PR publishes." CHANGELOG.md:4-10 adds a 0.46.1 section that contains only three chore(repo) lines. So the SDK's published code is identical to 0.46.0, yet a new Maven Central artifact and javadoc build would ship. release-please-config.json maps chore to a visible "Chores" section.

@claude claude Bot Oct 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 The public changelog and release notes would name a third-party provider and Sent's internal review setup, which CLAUDE.md forbids. The 9a83386 subject in this entry names "the managed Claude Code Review". CLAUDE.md says: "Nothing in it, including PR text, CHANGELOG.md and release notes, links to or names Sent's private repositories, internal systems or providers." Fix: remove this line from the 0.46.1 section and from the release notes before merging. Also check the other entries for internal tooling names.

Why this was flagged

release-please copied the commit subject "rely on the managed Claude Code Review, drop the workflow" from 9a83386 into CHANGELOG.md:10. It put the same text in the release PR body, which becomes the GitHub release notes when merged. The subject names an external provider (Claude) and describes how Sent reviews PRs internally. The commit body adds that this review is enabled in the Claude admin console. CLAUDE.md, under Commits and pull requests, bans naming internal systems or providers anywhere in CHANGELOG.md and release notes. REVIEW.md lists this as Important. The base CHANGELOG.md has no such line. After merging, the line is published permanently in the public repo and the release notes.

Verification: Trigger: a maintainer merges this release PR, which publishes CHANGELOG.md and the GitHub release notes. The line this diff adds at CHANGELOG.md:10 reads "* repo: rely on the managed Claude Code Review, drop the workflow (9a83386)". It names a third-party provider's service ("Claude Code Review") and describes Sent's internal PR-review setup.


## [0.46.0](https://github.com/sentdm/sent-dm-java/compare/v0.45.0...v0.46.0) (2026-10-28)


Expand Down
10 changes: 5 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

<!-- x-release-please-start-version -->

[![Maven Central](https://img.shields.io/maven-central/v/dm.sent/sent-java)](https://central.sonatype.com/artifact/dm.sent/sent-java/0.46.0)
[![javadoc](https://javadoc.io/badge2/dm.sent/sent-java/0.46.0/javadoc.svg)](https://javadoc.io/doc/dm.sent/sent-java)
[![Maven Central](https://img.shields.io/maven-central/v/dm.sent/sent-java)](https://central.sonatype.com/artifact/dm.sent/sent-java/0.46.1)
[![javadoc](https://javadoc.io/badge2/dm.sent/sent-java/0.46.1/javadoc.svg)](https://javadoc.io/doc/dm.sent/sent-java)

<!-- x-release-please-end -->

Expand All @@ -13,7 +13,7 @@ It is generated with [Stainless](https://www.stainless.com/).

<!-- x-release-please-start-version -->

The REST API documentation can be found on [docs.sent.dm](https://docs.sent.dm). Javadocs are available on [javadoc.io](https://javadoc.io/doc/dm.sent/sent-java/0.46.0).
The REST API documentation can be found on [docs.sent.dm](https://docs.sent.dm). Javadocs are available on [javadoc.io](https://javadoc.io/doc/dm.sent/sent-java/0.46.1).

<!-- x-release-please-end -->

Expand All @@ -24,7 +24,7 @@ The REST API documentation can be found on [docs.sent.dm](https://docs.sent.dm).
### Gradle

```kotlin
implementation("dm.sent:sent-java:0.46.0")
implementation("dm.sent:sent-java:0.46.1")
```

### Maven
Expand All @@ -33,7 +33,7 @@ implementation("dm.sent:sent-java:0.46.0")
<dependency>
<groupId>dm.sent</groupId>
<artifactId>sent-java</artifactId>
<version>0.46.0</version>
<version>0.46.1</version>
</dependency>
```

Expand Down
2 changes: 1 addition & 1 deletion build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ repositories {

allprojects {
group = "dm.sent"
version = "0.46.0" // x-release-please-version
version = "0.46.1" // x-release-please-version
}

subprojects {
Expand Down
Loading