Repository navigation
release: 0.46.1 - #57
Conversation
There was a problem hiding this comment.
Apart from the inline findings, I checked the version bump itself. 0.46.1 appears in the manifest, the build.gradle.kts version constant and every README badge, link and dependency snippet. No 0.46.0 reference remains outside CHANGELOG.md.
Extended reasoning...
I compared the version strings in .release-please-manifest.json, build.gradle.kts and README.md, then searched the repository for any leftover 0.46.0 outside the changelog.
Findings marked 🟡 are optional suggestions and need no follow-up push.
|
|
||
|
|
||
| ### Chores | ||
|
|
||
| * **repo:** add the contributor contract and review rubric ([373021e](https://github.com/sentdm/sent-dm-java/commit/373021e7e009906672ae32ea19c1c27e158ff10b)) | ||
| * **repo:** add the contributor contract and the review workflow ([d8b5e53](https://github.com/sentdm/sent-dm-java/commit/d8b5e535e32b70a61b140ecf46f181d7c712552a)) | ||
| * **repo:** rely on the managed Claude Code Review, drop the workflow ([9a83386](https://github.com/sentdm/sent-dm-java/commit/9a83386e0e37e29f8d43992ef738711b658745ae)) |
There was a problem hiding this comment.
🔴 Merging this publishes 0.46.1 to Maven Central with no change customers can see. Its release notes describe only internal repo tooling. All three entries are chore(repo) commits adding contributor and review files, a type that cuts a release for an invisible change. One line also names an internal review vendor, "the managed Claude Code Review". Fix: hold this release PR until a customer-facing change lands, and drop or retitle the three repo-only lines (e.g. as ci:, which is hidden) so no published note names internal tooling.
Why this was flagged
The trigger is a maintainer merging this release PR. CLAUDE.md says "Merging the release PR publishes." The 0.46.1 section in CHANGELOG.md:4-10 lists only three chore(repo) commits: 373021e, d8b5e53 and 9a83386. They add or remove the contributor contract, the review rubric and the review workflow. The diff bumps build.gradle.kts:11 and README.md to 0.46.1, but the SDK code is the same as 0.46.0. Customers therefore get a new Maven Central artifact and javadoc build with no behaviour change. Their release notes describe internal process, and the line at CHANGELOG.md:10 names an internal review tool. REVIEW.md lists "a type that cuts a release for a change customers don't see" and an internal cause as Important. CLAUDE.md says changelog subjects must be written for customers, "Never an internal cause", and that nothing in CHANGELOG.md may name Sent's internal systems or providers. On the base branch, 0.46.0 stays the latest release and these lines are never published.
Verification: The trigger is a maintainer merging this release PR. CLAUDE.md:54 says "Merging the release PR publishes." CHANGELOG.md:4-10 adds a 0.46.1 section that contains only three chore(repo) lines. So the SDK's published code is identical to 0.46.0, yet a new Maven Central artifact and javadoc build would ship. release-please-config.json maps chore to a visible "Chores" section.
|
|
||
| * **repo:** add the contributor contract and review rubric ([373021e](https://github.com/sentdm/sent-dm-java/commit/373021e7e009906672ae32ea19c1c27e158ff10b)) | ||
| * **repo:** add the contributor contract and the review workflow ([d8b5e53](https://github.com/sentdm/sent-dm-java/commit/d8b5e535e32b70a61b140ecf46f181d7c712552a)) | ||
| * **repo:** rely on the managed Claude Code Review, drop the workflow ([9a83386](https://github.com/sentdm/sent-dm-java/commit/9a83386e0e37e29f8d43992ef738711b658745ae)) |
There was a problem hiding this comment.
🔴 The public changelog and release notes would name a third-party provider and Sent's internal review setup, which CLAUDE.md forbids. The 9a83386 subject in this entry names "the managed Claude Code Review". CLAUDE.md says: "Nothing in it, including PR text, CHANGELOG.md and release notes, links to or names Sent's private repositories, internal systems or providers." Fix: remove this line from the 0.46.1 section and from the release notes before merging. Also check the other entries for internal tooling names.
Why this was flagged
release-please copied the commit subject "rely on the managed Claude Code Review, drop the workflow" from 9a83386 into CHANGELOG.md:10. It put the same text in the release PR body, which becomes the GitHub release notes when merged. The subject names an external provider (Claude) and describes how Sent reviews PRs internally. The commit body adds that this review is enabled in the Claude admin console. CLAUDE.md, under Commits and pull requests, bans naming internal systems or providers anywhere in CHANGELOG.md and release notes. REVIEW.md lists this as Important. The base CHANGELOG.md has no such line. After merging, the line is published permanently in the public repo and the release notes.
Verification: Trigger: a maintainer merges this release PR, which publishes CHANGELOG.md and the GitHub release notes. The line this diff adds at CHANGELOG.md:10 reads "* repo: rely on the managed Claude Code Review, drop the workflow (9a83386)". It names a third-party provider's service ("Claude Code Review") and describes Sent's internal PR-review setup.
|
|
||
| * **repo:** add the contributor contract and review rubric ([373021e](https://github.com/sentdm/sent-dm-java/commit/373021e7e009906672ae32ea19c1c27e158ff10b)) | ||
| * **repo:** add the contributor contract and the review workflow ([d8b5e53](https://github.com/sentdm/sent-dm-java/commit/d8b5e535e32b70a61b140ecf46f181d7c712552a)) |
There was a problem hiding this comment.
🟡 (optional) Customers reading the 0.46.1 notes get one change listed three times, including a workflow that is "added" and then "dropped" in the same release. Line 7 links merge commit 373021e, whose body repeats the subject of PR #8. Lines 8 and 9 are the two commits that PR merged, d8b5e53 and 9a83386. Fix: give one changed thing one customer-facing line, and drop the add-then-remove workflow pair, which never shipped. For example, use a release-please BEGIN_COMMIT_OVERRIDE on 373021e, or edit the release PR notes. Squash-merging PRs with conventional subjects prevents this happening again.
Why this was flagged
The trigger is merging this release PR. Release-please parsed both the merge commit 373021e (body "chore(repo): add the contributor contract and review rubric", parents 89134db and 9a83386) and the two commits it brought in. Commit d8b5e53 adds .github/workflows/claude-pr-review.yml, and 9a83386 deletes it, so on net no workflow reaches main. CHANGELOG.md:7-9 and the GitHub release notes therefore list the CLAUDE.md/REVIEW.md/CODEOWNERS addition twice. They also announce a workflow added and a workflow dropped, which cancel each other out. The 0.46.0 section has no such duplicates. CLAUDE.md says "The subject becomes the changelog line customers read, so write it for them". Release-please does not dedupe a merge-commit body against the commits it merges.
Verification: Nit. Triggered when this release PR is merged and the 0.46.1 notes are published. Merge commit 373021e's body is parsed as its own entry at CHANGELOG.md:7, repeating d8b5e53 (line 8). d8b5e53 adds .github/workflows/claude-pr-review.yml (+49) and 9a83386 (line 9) deletes it (-49), so no workflow ever reaches main.
|
🤖 Created releases: 🌻 |
Automated Release PR
0.46.1 (2026-10-30)
Maintenance
CLAUDE.md,REVIEW.md,CODEOWNERS). No API changes.This PR was generated with Release Please. See documentation.