Fix exceptions getting bulk_data.categories and plugins at startup#256
Merged
bburda merged 3 commits intoselfpatch:mainfrom Mar 7, 2026
Merged
Fix exceptions getting bulk_data.categories and plugins at startup#256bburda merged 3 commits intoselfpatch:mainfrom
bburda merged 3 commits intoselfpatch:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent ROS 2 startup exceptions caused by parameters that are configured as empty arrays in gateway_params.yaml (notably bulk_data.categories and plugins), which can trigger InvalidParameterValueException during parameter file parsing.
Changes:
- Update
bulk_data.categoriesdefault ingateway_params.yamlfrom[]to[""]. - Update
pluginsdefault ingateway_params.yamlfrom[]to[""].
bburda
previously approved these changes
Mar 7, 2026
Collaborator
bburda
left a comment
There was a problem hiding this comment.
LGTM +1 - thanks for the fix! 🚀
Collaborator
|
@nnarain could you please clang-format the code? |
Contributor
Author
|
Yup will do |
bburda
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
After building and trying to run medkit gateway I had the follow exceptions
Looks like this is done in a few places, just not for these params.
https://github.com/selfpatch/ros2_medkit/blob/main/src/ros2_medkit_gateway/config/gateway_params.yaml#L322
Issue
Link the related issue (required):
Type
Testing
Gateway started as expected.
Checklist