Skip to content

Fix exceptions getting bulk_data.categories and plugins at startup#256

Merged
bburda merged 3 commits intoselfpatch:mainfrom
nnarain:gateway-startup-fix
Mar 7, 2026
Merged

Fix exceptions getting bulk_data.categories and plugins at startup#256
bburda merged 3 commits intoselfpatch:mainfrom
nnarain:gateway-startup-fix

Conversation

@nnarain
Copy link
Contributor

@nnarain nnarain commented Mar 7, 2026

Pull Request

Summary

After building and trying to run medkit gateway I had the follow exceptions

[gateway_node-1] terminate called after throwing an instance of 'rclcpp::exceptions::InvalidParameterValueException'
[gateway_node-1] what(): parameter_value_from failed for parameter 'bulk_data.categories': No parameter value set
[ERROR] [gateway_node-1]: process has died [pid 78467, exit code -6, cmd '/workspaces/ros_ws/install/ros2_medkit_gateway/lib/ros2_medkit_gateway/gateway_node --ros-args --log-level info --ros-args -r __node:=ros2_medkit_gateway --params-file /workspaces/ros_ws/install/ros2_medkit_gateway/share/ros2_medkit_gateway/config/gateway_params.yaml --params-fevel info --ros-args -r __node:=ros2_medkiile /tmp/launch_params_3pu02a64'].
of 'rclcpp::exceptions::InvalidParameterValueException'
[gateway_node-1] what(): parameter_value_from failed for parameter 'bulk_data.categories': No parameter value set
[ERROR] [gateway_node-1]: process has died [pid 102916, exit code -6, cmd '/workspaces/ros_ws/install/ros2_medkit_gateway/lib/ros2_medkit_gateway/gateway_node --ros-args --log-level info --ros-args -r __node:=ros2_medkit_gateway --params-file /workspaces/ros_ws/install/ros2_medkit_gateway/share/ros2_medkit_gateway/config/gateway_params.yaml --params-file /tmp/launch_params_y0pyhd4w'].

Looks like this is done in a few places, just not for these params.

https://github.com/selfpatch/ros2_medkit/blob/main/src/ros2_medkit_gateway/config/gateway_params.yaml#L322


Issue

Link the related issue (required):


Type

  • Bug fix
  • New feature or tests
  • Breaking change
  • Documentation only

Testing

ros2 launch ros2_medkit_gateway gateway.launch.py

Gateway started as expected.


Checklist

  • Breaking changes are clearly described (and announced in docs / changelog if needed)
  • Tests were added or updated if needed
  • Docs were updated if behavior or public API changed

Copilot AI review requested due to automatic review settings March 7, 2026 03:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to prevent ROS 2 startup exceptions caused by parameters that are configured as empty arrays in gateway_params.yaml (notably bulk_data.categories and plugins), which can trigger InvalidParameterValueException during parameter file parsing.

Changes:

  • Update bulk_data.categories default in gateway_params.yaml from [] to [""].
  • Update plugins default in gateway_params.yaml from [] to [""].

bburda
bburda previously approved these changes Mar 7, 2026
Copy link
Collaborator

@bburda bburda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 - thanks for the fix! 🚀

@bburda bburda added the bug Something isn't working label Mar 7, 2026
@bburda
Copy link
Collaborator

bburda commented Mar 7, 2026

@nnarain could you please clang-format the code?

@nnarain
Copy link
Contributor Author

nnarain commented Mar 7, 2026

Yup will do

@bburda bburda merged commit 0714171 into selfpatch:main Mar 7, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] InvalidParameterValueException on gateway startup

3 participants