Skip to content

Fix memory allocation error by lazy loading latent_gt_dict #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mr-Neutr0n wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix memory allocation error by lazy loading latent_gt_dict #441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions basicsr/data/ffhq_blind_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,11 @@ def __init__(self, opt):
self.crop_components = False

if self.latent_gt_path is not None:
self.load_latent_gt = True
self.latent_gt_dict = torch.load(self.latent_gt_path)
self.load_latent_gt = True
self.latent_gt_dict = None # Lazy load to avoid memory issues with multi-process DataLoader
else:
self.load_latent_gt = False
self.load_latent_gt = False
self.latent_gt_dict = None

if self.io_backend_opt['type'] == 'lmdb':
self.io_backend_opt['db_paths'] = self.gt_folder
Expand Down Expand Up @@ -190,6 +191,9 @@ def __getitem__(self, index):
img_gt, status = augment(img_gt, hflip=self.opt['use_hflip'], rotation=False, return_status=True)

if self.load_latent_gt:
# Lazy load latent_gt_dict to avoid memory issues with multi-process DataLoader
if self.latent_gt_dict is None:
self.latent_gt_dict = torch.load(self.latent_gt_path)
if status[0]:
latent_gt = self.latent_gt_dict['hflip'][name]
else:
Expand Down