Fix memory allocation error by lazy loading latent_gt_dict#441
Open
Mr-Neutr0n wants to merge 1 commit intosczhou:masterfrom
Open
Fix memory allocation error by lazy loading latent_gt_dict#441Mr-Neutr0n wants to merge 1 commit intosczhou:masterfrom
Mr-Neutr0n wants to merge 1 commit intosczhou:masterfrom
Conversation
Author
|
any chance someone could take a look at this? it fixes a memory allocation crash when loading latent_gt_dict by deferring it to when it's actually needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RuntimeError: unable to mmap XXX bytes from filewhen using multi-process DataLoader withnum_workers > 0Problem
When
latent_gt_pathpoints to a large.pthfile (e.g., ~1.6GB), loading it in__init__causes memory issues:Solution
Implemented lazy loading of
latent_gt_dict:self.latent_gt_dict = Nonein__init__instead of loading immediately__getitem__This ensures each worker process loads the data independently when needed, avoiding the shared memory issues.
Related Issue
Fixes #435
Test Plan
num_workers > 0should no longer cause memory allocation errors