Repository navigation
fix(health): add /health/ready to srv-qa — 404 crash-loop aborted MTA deploy (#2975) - #3000
Merged
Merged
Conversation
…QA, aborting MTA deploy (#2975) The #2975 batch set srv-qa's CF startup health check to http /health/ready (mta.yaml:199, parity with tutorials-srv) but never added that route to srv-qa/server.js — it only has /healthz and /health/db. So CF's probe got a 404, srv-qa crash-looped (3 retries), and the ENTIRE MTA deploy aborted even though tutorials-srv itself started fine. (Observed on the 2026-11-02 DEV deploy.) srv-qa has no scheduler, so its readiness is DB-only: ready ⇔ a dialect-safe HANA ping (SELECT 1 FROM DUMMY — a bare SELECT 1 is a HANA syntax error) succeeds. Also made /health/db dialect-safe (it hardcoded FROM DUMMY, which breaks on local SQLite). Unit tests cover both dialects + the down path. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Follow-on to #2995. The 2026-11-02 DEV deploy got past the main app (
tutorials-srvstarted cleanly — #2995's HANA fix works) but aborted becausetutorials-srv-qacrash-looped:The #2975 batch set srv-qa's CF startup health check to
http /health/ready(mta.yaml:199, parity with tutorials-srv) but never added that route tosrv-qa/server.js— it only has/healthzand/health/db. CF's probe 404s → srv-qa never healthy → MTA deploy aborts.Fix
/health/readytosrv-qa/server.js. srv-qa has no scheduler, so readiness is DB-only: ready ⇔ a dialect-safe DB ping succeeds (SELECT 1 FROM DUMMYon HANA — bareSELECT 1is a HANA syntax error; bareSELECT 1on SQLite)./health/dbdialect-safe too (it hardcodedFROM DUMMY, broken on local SQLite).Why it matters
Without this, the DEV→main release (carrying #2992 draft fix + #2975 readiness gate + others) cannot deploy — the MTA aborts on srv-qa every time.
Related: #2975, #2995.
🤖 Generated with Claude Code