Repository navigation
revert(db): remove draft cascade-constraint patch blocking deploy (#2993) - #3003
Merged
Merged
Conversation
…d delete is off, blocking deploy (#2993) The #2993 build patch generated ON DELETE CASCADE constraints for draft tables to support CAP 10.2's optimized draft deletion (dad strategy / cds.fiori.draft_admin_integrity). But: 1. The constraints are ONLY needed when draft_admin_integrity is ON. It is OFF (#2992) and staying off — orphan cleanup is handled by scripts/cleanup-draft-orphans.cjs (#2994) instead. So the constraints provide zero value right now. 2. Both delivery forms failed HDI: inline-in-.hdbtable (error 8250014), then standalone .hdbconstraint (error 8212001 — the ON <table> clause needs the base .hdbtable in the same make graph, which a delta deploy doesn't provide). Making it work is unresolved HDI-delta research. 3. It aborts tutorials-db-deployer on every deploy, blocking urgent PROD fixes (the #2909 draft-edit fix + #2995/#3000 health-gate fixes) from reaching DEV and then prod. Remove the build-time patch entirely: the .deploy/mta.yaml builder line, the script, and its unit test. Re-enabling the dad strategy later is tracked by #2993 and requires solving the HDI make-graph dependency first (likely a CAP-native constraint mechanism, not a hand-rolled patch). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The #2993 build-time cascade-constraint patch is aborting every MTA deploy at
tutorials-db-deployer, and it provides no value right now:daddraft-delete strategy (cds.fiori.draft_admin_integrity). That flag is OFF (fix(cap): disable draft_admin_integrity — missing HANA cascade corrupted mission drafts (#2909) #2992) and staying off; orphan cleanup is handled byscripts/cleanup-draft-orphans.cjs(feat(ops): cleanup-draft-orphans.cjs — sweep orphaned draft rows (#2909/#2993) #2994)..hdbtable(error 8250014 "must not have references"), then standalone.hdbconstraint(error 8212001 —ON <table>needs the base.hdbtablein the same make graph, which a delta deploy doesn't provide; "Could not compose a consistent make graph"). Getting it HDI-valid on a delta container is unresolved.Change
Remove the patch entirely:
.deploy/mta.yamlbuilder line that ran the patchscripts/patch-draft-cascade-constraints.cjstest/unit/patch-draft-cascade-constraints.test.jsNo runtime behavior change — the flag was already off, so no constraints were active. YAML validated.
Follow-up
Re-enabling the
dadstrategy is tracked by #2993 and must first solve the HDI make-graph dependency (the base.hdbtable+.hdbconstraintco-deploy problem), likely via a CAP-native mechanism rather than a hand-rolled build patch.Related: #2993, #2992, #2909.
🤖 Generated with Claude Code