Skip to content

fix: handle null MCP asset input #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
konkonrong-lgtm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle null MCP asset input #472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/commands/agent/mcp/asset/replace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,9 @@ export default class ApiCatalogMcpServerAssetReplace extends SfCommand<ApiCatalo
throw new SfError(messages.getMessage('error.invalidJson'), 'InvalidJson', [], 1);
}

const assets = (Array.isArray(parsed) ? parsed : (parsed as { assets?: McpServerAssetReplaceItem[] }).assets) as
| McpServerAssetReplaceItem[]
| undefined;
const assets = (
Array.isArray(parsed) ? parsed : (parsed as { assets?: McpServerAssetReplaceItem[] } | null)?.assets
) as McpServerAssetReplaceItem[] | undefined;
if (!assets || !Array.isArray(assets)) {
throw new SfError(messages.getMessage('error.invalidShape'), 'InvalidShape', [], 1);
}
Expand Down
13 changes: 13 additions & 0 deletions test/commands/agent/mcp/mcp.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,19 @@ describe('agent mcp commands', () => {
}
});

it('asset replace throws InvalidShape for null JSON', async () => {
const testOrg = new MockTestOrgData();
await $$.stubAuths(testOrg);
$$.fakeConnectionRequest = () => Promise.resolve({} as any);

try {
await AgentMcpAssetReplace.run(['--target-org', testOrg.username, '--mcp-server-id', '0XS1', '--assets', 'null']);
expect.fail('should have thrown');
} catch (err) {
expect((err as { name: string }).name).to.equal('InvalidShape');
}
});

it('get returns the server and strips the secret on read', async () => {
const testOrg = new MockTestOrgData();
await $$.stubAuths(testOrg);
Expand Down