fix: handle null MCP asset input - #472
Open
konkonrong-lgtm wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Handles
nullJSON input passed tosf agent mcp asset replace --assets.Previously,
nullwas successfully parsed as JSON and the command attempted to access.assetson it, resulting in a rawTypeError:This change uses safe property access so invalid input falls through to the existing
InvalidShapevalidation.A regression test was added for
--assets null.Test results:
yarn test:only— 448 passingyarn build— successfulWhat issues does this PR fix or reference?
Fixes forcedotcom/cli#3625