fix: preserve object MIME types and download names - #238
Merged
Merged
Conversation
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Uploading files through the Console could persist a browser's generic MIME type even when the object name provided a more specific type. This caused archive objects such as
test.tar.xzto be stored asapplication/x-compressed, and direct browser downloads could be saved with the wrong extension. The upload resolver now uses shared filename MIME inference when the browser type is generic, including compound archive suffixes, while preserving specific browser types. Download-only presigned URLs now request an explicit RFC 5987 attachment filename without changing preview or share URLs.Type of Change
Testing
All checks passed; the test suite reported 599 passing tests.
Checklist
Related Issues
Closes rustfs/rustfs#8027
Screenshots (if applicable)
N/A: this change affects upload metadata and download response headers; no new visual UI is introduced.
Additional Notes
The server continues to preserve explicitly supplied S3 metadata. Only download actions request
response-content-disposition; preview and shared temporary URLs retain their existing inline behavior.