fix: encode extended download filenames - #239
Merged
Merged
Conversation
cxymds
force-pushed
the
fix/rfc8187-content-disposition
branch
from
September 20, 2026 09:57
5d92ffa to
384cbe1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Correct RFC 8187 encoding for extended download filenames.
encodeURIComponentleaves',(,)and*unescaped, but those characters are not valid in thefilename*value. Encode them so Unicode object names containing these characters are preserved by browsers instead of falling back to the sanitized ASCII filename.Type of Change
Testing
All checks pass; the test suite reports 600 passing tests.
Checklist
Related Issues
Related to rustfs/rustfs#8027 and #238.
Screenshots (if applicable)
N/A: this change affects HTTP header encoding only; no visual UI is introduced.
Additional Notes
This is a follow-up to #238 and is intentionally limited to the RFC 8187 filename encoding boundary.