Skip to content

fix(kms): unsupported cases must not fail a plain lane run #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
majinghe merged 1 commit into from
Oct 31, 2026
Merged

fix(kms): unsupported cases must not fail a plain lane run #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion rustfs-kms-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2373,7 +2373,13 @@ main() {
fi
fi
if [ "${FAIL}" -gt 0 ]; then overall_fail=1; fi
if [ "${UNSUPPORTED}" -gt 0 ] || [ "${cleanup_status}" != PASS ]; then overall_fail=1; fi
# A teardown failure is a real infra error in any mode. UNSUPPORTED
# cases (environment gates such as the rc-restart exit-7 skip) are
# expected in plain lane runs — the validation flow is the only mode
# that treats them as incomplete. Failing the lane on them made every
# topology exit 1 despite PASS=42/43 FAIL=0 (chain 40796474356).
if [ "${cleanup_status}" != PASS ]; then overall_fail=1; fi
if [ -n "${VALIDATION_CASE}" ] && [ "${UNSUPPORTED}" -gt 0 ]; then overall_fail=1; fi
done
done
final_summary
Expand Down
Loading