Repository navigation
fix(kms): unsupported cases must not fail a plain lane run - #121
Merged
Merged
Conversation
#113's validation migration made any UNSUPPORTED topology result set overall_fail, so every kms topology exited 1 despite PASS=42/43 FAIL=0 (6-7 rc-restart-gated skips per topology are the expected lane shape). Keep teardown failures fatal everywhere; treat UNSUPPORTED as incomplete only in validation mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chain 40796474356: every kms topology printed
PASS=42/43 FAIL=0 UNSUPPORTED=6/7and the driver still exited 1, invalidating the lane.#113's validation migration added
so the 6-7 environment-gated skips per topology (rc-restart exit-7 gating and friends — the lane's long-standing shape, 39 aggregated UNSUPPORTED in every green historical run) flipped the driver to failure.
Keep teardown failures fatal in every mode; treat UNSUPPORTED as incomplete only when actually running as a validation case (
VALIDATION_CASEset), which is where #113's strictness belongs.