Skip to content

ci(windows): move cargo clippy step to release build mode #5075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rami3l merged 1 commit into from
Sep 14, 2026
+4 −4
Merged

ci(windows): move cargo clippy step to release build mode #5075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ jobs:
BUILD_PROFILE: ${{ matrix.mode }}
run: bash ci/run.bash
- name: Run cargo clippy
if: matrix.mode != 'release' && matrix.mingwdir == ''
if: matrix.mode == 'release' && matrix.mingwdir == ''
env:
TARGET: ${{ matrix.target }}
# os-specific code leads to lints escaping if we only run this in one target
Expand Down Expand Up @@ -350,7 +350,7 @@ jobs:
BUILD_PROFILE: ${{ matrix.mode }}
run: bash ci/run.bash
- name: Run cargo clippy
if: matrix.mode != 'release' && matrix.mingwdir == ''
if: matrix.mode == 'release' && matrix.mingwdir == ''
env:
TARGET: ${{ matrix.target }}
# os-specific code leads to lints escaping if we only run this in one target
Expand Down Expand Up @@ -547,7 +547,7 @@ jobs:
BUILD_PROFILE: ${{ matrix.mode }}
run: bash ci/run.bash
- name: Run cargo clippy
if: matrix.mode != 'release' && matrix.mingwdir == ''
if: matrix.mode == 'release' && matrix.mingwdir == ''
env:
TARGET: ${{ matrix.target }}
# os-specific code leads to lints escaping if we only run this in one target
Expand Down
2 changes: 1 addition & 1 deletion ci/actions-templates/windows-builds-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ jobs: # skip-main skip-pr skip-stable
BUILD_PROFILE: ${{ matrix.mode }}
run: bash ci/run.bash
- name: Run cargo clippy
if: matrix.mode != 'release' && matrix.mingwdir == ''
if: matrix.mode == 'release' && matrix.mingwdir == ''
env:
TARGET: ${{ matrix.target }}
# os-specific code leads to lints escaping if we only run this in one target
Expand Down
Loading