ci(windows): move cargo clippy step to release build mode - #5075
Merged
Merged
Conversation
rami3l
marked this pull request as ready for review
September 14, 2026 07:35
djc
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #5074.
On Windows,
cargo clippyis only run when compiling to MSVC targets, and currently only on thedevbuild mode, where we are already additionally running the full test suite.Thus, I wonder if running
cargo clippyonreleasewill save us a few minutes more.Outcome
TLDR: A wall time save of ~8mins for the Windows matrix compared to the original, and ~5mins compared to after #5074.
Original state (27mins), at https://github.com/rust-lang/rustup/actions/runs/34693481373:
After #5074 (25mins), at https://github.com/rust-lang/rustup/actions/runs/34750325642?pr=5074:
After this patch (19mins), at https://github.com/rust-lang/rustup/actions/runs/34780526239?pr=5075: