Skip to content

fix -Z track-diagnostics for errors and lints emitted from rustc_attr_parsing - #163755

Merged
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
mejrs:attr_parsing_track_diagnostics
Oct 5, 2026
Merged

rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
mejrs:attr_parsing_track_diagnostics

Conversation

@mejrs

@mejrs mejrs commented Oct 4, 2026

Copy link
Copy Markdown
Member

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 4, 2026
@mejrs
mejrs marked this pull request as ready for review October 4, 2026 12:45
@rustbot

rustbot commented Oct 4, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 4, 2026

@JonathanBrouwer JonathanBrouwer left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors

rust-bors Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

📌 Commit dcce9b0 has been tentatively approved by JonathanBrouwer

It will be put into the queue for this repository once PR CI succeeds.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2026
@rust-log-analyzer

This comment has been minimized.

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 4, 2026
@rust-bors

rust-bors Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

❌ Commit dcce9b0 has been unapproved due to PR CI failure. Reapprove it with @bors r+ force if you want to ignore the failure.

@mejrs
mejrs force-pushed the attr_parsing_track_diagnostics branch from dcce9b0 to 90c7f95 Compare October 4, 2026 15:04
@rustbot

rustbot commented Oct 4, 2026

Copy link
Copy Markdown
Collaborator

clippy is developed in its own repository. If possible, consider making this change to rust-lang/rust-clippy instead.

cc @rust-lang/clippy

@rustbot rustbot added the T-clippy Relevant to the Clippy team. label Oct 4, 2026
@mejrs

mejrs commented Oct 4, 2026

Copy link
Copy Markdown
Member Author

@bors r=jonathanbrouwer

@rust-bors

rust-bors Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 90c7f95 has been tentatively approved by jonathanbrouwer

It will be put into the queue for this repository once PR CI succeeds.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 4, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 4, 2026
…athanbrouwer

fix -Z track-diagnostics for errors and lints emitted from rustc_attr_parsing

r? @GuillaumeGomez or perhaps @JonathanBrouwer
rust-bors Bot pushed a commit that referenced this pull request Oct 4, 2026
…uwer

Rollup of 6 pull requests

Successful merges:

 - #161491 (Rip out old solver coherence)
 - #163223 (regression test for async handler normalization ICE)
 - #163653 (callconv: mips64: Match GCC for alignment of 16-byte scalars)
 - #163742 (Add the `movdir64b` and `movdiri` x86 target features)
 - #163752 (Revert "implement PartialEq<VecDeque<U>> for Vec<T>, &[T], &mut [T], [T; N], &[T; N] and &mut [T; N]")
 - #163755 (fix -Z track-diagnostics for errors and lints emitted from rustc_attr_parsing)
@JonathanBrouwer

Copy link
Copy Markdown
Member

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #163763 (comment)

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 4, 2026
@rust-bors

rust-bors Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

This PR was contained in a rollup (#163763), which was unapproved.

View changes since this unapproval

@mejrs

mejrs commented Oct 4, 2026

Copy link
Copy Markdown
Member Author

oops i forgor the normalization

@mejrs
mejrs force-pushed the attr_parsing_track_diagnostics branch from 90c7f95 to 6d99887 Compare October 4, 2026 21:25
@mejrs

mejrs commented Oct 4, 2026

Copy link
Copy Markdown
Member Author

@bors r=jonathanbrouwer

@rust-bors

rust-bors Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 6d99887 has been tentatively approved by jonathanbrouwer

It will be put into the queue for this repository once PR CI succeeds.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 4, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 5, 2026
Rollup of 2 pull requests

Successful merges:

 - #146099 (Stabilize `debug_closure_helpers`)
 - #163755 (fix -Z track-diagnostics for errors and lints emitted from rustc_attr_parsing)
@rust-bors
rust-bors Bot merged commit 8bb0a7d into rust-lang:main Oct 5, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 5, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 5, 2026
Rollup merge of #163755 - mejrs:attr_parsing_track_diagnostics, r=jonathanbrouwer

fix -Z track-diagnostics for errors and lints emitted from rustc_attr_parsing

r? @GuillaumeGomez or perhaps @JonathanBrouwer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants