Skip to content

Rollup of 2 pull requests - #163774

Merged
rust-bors[bot] merged 8 commits into
rust-lang:mainfrom
jhpratt:rollup-BbGMOsp
Oct 5, 2026
Merged

rust-bors[bot] merged 8 commits into
rust-lang:mainfrom
jhpratt:rollup-BbGMOsp

Conversation

@jhpratt

@jhpratt jhpratt commented Oct 5, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

mejrs and others added 8 commits October 4, 2026 12:16
…re_helpers, r=tgross35

Stabilize `debug_closure_helpers`

Resolves rust-lang#117729. The tracking issue still needs an FCP, but I'm hoping that creating a stabilization PR will prompt one.

r? libs-api
…cs, r=jonathanbrouwer

fix -Z track-diagnostics for errors and lints emitted from rustc_attr_parsing

r? @GuillaumeGomez or perhaps @JonathanBrouwer
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Oct 5, 2026
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 5, 2026
@jhpratt

jhpratt commented Oct 5, 2026

Copy link
Copy Markdown
Member Author

@bors r+ p=5 force

@rust-bors

rust-bors Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 8bb0a7d has been approved by jhpratt

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 5, 2026
@rust-bors

rust-bors Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 6m 35s
Pushing cc9a14f to main...

@rust-bors
rust-bors Bot merged commit cc9a14f into rust-lang:main Oct 5, 2026
15 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 5, 2026
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 260f1ac (parent) -> cc9a14f (this PR)

Test differences

Show 113 test diffs

Stage 1

  • [ui] tests/ui/track-diagnostics/track8.rs: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/track-diagnostics/track8.rs: [missing] -> pass (J2)

Stage 2

  • [ui] tests/ui/track-diagnostics/track8.rs: [missing] -> pass (J0)

Additionally, 110 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard cc9a14f721fac5226338c61dcec7d5ab785bde82 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. test-x86_64-msvc-ext3: 1h 6m -> 2h (+79.5%)
  2. dist-loongarch64-musl: 1h 16m -> 2h 3m (+61.1%)
  3. dist-i686-msvc: 33m 36s -> 53m 7s (+58.1%)
  4. test-various: 1h 29m -> 2h 19m (+55.9%)
  5. dist-x86_64-mingw: 1h 41m -> 2h 35m (+53.4%)
  6. test-x86_64-gnu-gcc-core-tests: 12m 29s -> 18m 23s (+47.3%)
  7. test-x86_64-gnu-llvm-22: 38m 40s -> 56m 53s (+47.1%)
  8. dist-ohos-x86_64: 56m 58s -> 1h 23m (+45.9%)
  9. test-i686-gnu-2: 1h 9m -> 1h 39m (+42.2%)
  10. test-x86_64-gnu-miri: 1h 31m -> 54m 56s (-40.1%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (cc9a14f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.2% [2.2%, 2.2%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.2% [2.2%, 2.2%] 1

Cycles

Results (primary -2.0%, secondary -1.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.5% [2.4%, 2.7%] 3
Improvements ✅
(primary)
-2.0% [-2.0%, -2.0%] 1
Improvements ✅
(secondary)
-15.1% [-15.1%, -15.1%] 1
All ❌✅ (primary) -2.0% [-2.0%, -2.0%] 1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 490.682s -> 489.361s (-0.27%)
Artifact size: 408.64 MiB -> 408.63 MiB (-0.00%)

@rust-bors

rust-bors Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#146099 Stabilize debug_closure_helpers f077e60ffb36a894a984b4ebb16170cae2ebde20
(link)
#163755 fix -Z track-diagnostics for errors and lints emitted from … d9cb5bfec603437d0f130c58002cf171a2d12d13
(link)

parent commit: 260f1acad9

In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: @rust-timer triage $SHA $SHA $SHA..., or run @rust-timer triage all to benchmark all rollup members.

@jhpratt
jhpratt deleted the rollup-BbGMOsp branch October 6, 2026 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants