Revert #159844

[GuillaumeGomez]

r? @JonathanBrouwer

[rustbot]

rustc_codegen_gcc is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_gcc instead.

cc @antoyo

[rustbot]

⚠️ Warning ⚠️

• Some commits in this PR modify submodules.

  If this was not intentional, see I changed a submodule on accident in the rustc dev guide.

• There are issue links (such as #123) in the commit messages of the following commits.
  Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

  • bf57193

[JonathanBrouwer]

@bors r+ p=1000

[rust-bors]

📌 Commit bf57193 has been approved by JonathanBrouwer

It is now in the queue for this repository.

[JonathanBrouwer]

@bors treeopen

[rust-bors]

Tree is now open for merging.

[RalfJung]

FWIW this will be very interesting to figure out in terms of what it does with subtree syncs... it might be a lot of work to get the next sync going. But we probably don't have a better choice now as this breaks too many things.

[rust-bors]

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 12m 7s
Pushing c9ff496 to main...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5048696 (parent) -> c9ff496 (this PR)

Test differences

Show 3 test diffs

3 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard c9ff496891c278ad660bc0ab85c1f0b72059464a --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. x86_64-gnu-nopt: 1h 31m -> 2h 14m (+46.8%)
2. dist-various-2: 30m 23s -> 40m 42s (+34.0%)
3. dist-i686-mingw: 2h 57m -> 2h 5m (-29.4%)
4. x86_64-gnu-parallel-frontend: 1h 49m -> 1h 19m (-27.2%)
5. i686-msvc-2: 1h 36m -> 2h 1m (+26.8%)
6. x86_64-msvc-ext1: 2h 18m -> 1h 42m (-25.8%)
7. x86_64-gnu-distcheck: 1h 40m -> 2h 6m (+25.6%)
8. x86_64-gnu-gcc: 1h 7m -> 51m 2s (-24.3%)
9. dist-x86_64-msvc: 1h 47m -> 2h 12m (+23.2%)
10. dist-powerpc64-linux-musl: 1h 18m -> 1h 35m (+22.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (c9ff496): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.2%, secondary 0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.5%	[0.4%, 0.7%]	5
Improvements ✅ (primary)	-2.2%	[-3.8%, -0.6%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.2%	[-3.8%, -0.6%]	2

Cycles

Results (primary 1.2%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.7%	[0.5%, 7.6%]	10
Regressions ❌ (secondary)	1.0%	[0.5%, 1.8%]	6
Improvements ✅ (primary)	-0.6%	[-0.6%, -0.5%]	3
Improvements ✅ (secondary)	-0.7%	[-1.4%, -0.4%]	6
All ❌✅ (primary)	1.2%	[-0.6%, 7.6%]	13

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 491.182s -> 489.838s (-0.27%)
Artifact size: 390.23 MiB -> 390.28 MiB (0.01%)