Temporarily stop emitting the retain attribute to fix the GCC CI - #160474
Temporarily stop emitting the retain attribute to fix the GCC CI#160474antoyo wants to merge 1 commit into
Conversation
|
|
rustbot
added
S-waiting-on-review
|
rustbot has assigned @JonathanBrouwer. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
☔ The latest upstream changes (presumably #160468) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
rustbot
removed
the
S-waiting-on-review
| pub fn add_retained_global(&mut self, global: LValue<'gcc>) { | ||
| // We need to add the `used` C attribute in any case. | ||
| self.add_used_global(global); | ||
| #[cfg(feature = "master")] |
There was a problem hiding this comment.
What was this cfg gate for? Could that be related to our ci funkiness?
There was a problem hiding this comment.
No, that line is now commented as you can see below.
As discussed on Zulip, it seems the issue is that the machine where GCC is built is using a binutils that is too old, so the retain attributed is effectively disabled.
There was a problem hiding this comment.
What was this cfg gate for?
cg_gcc still supports the old libgccjit version 12 and this cfg gate is needed to say that the following code is only available on the latest libgccjit git version (from our gcc fork).
3 participants
No description provided.