ci: enable workspace lint rules#963
Conversation
|
I'll tack on a commit to fix up the lints if cool with this approach. |
|
Should we bump the rbmt-version commit? |
|
Yea, let me see how easy it is to update to v0.3.0 |
|
concept ACK. Interesting to just turn on The lint is particularly useful here because we have a lot of generics, and |
| [lints] | ||
| workspace = true |
There was a problem hiding this comment.
Gee wiz, so this is the only thing I was missing. Face palm.
|
How about I grab this patch then the ones from #944 sans the re-name and we push that up first? (And I'll include the 'stop using ::*` thing as suggested on that PR.) |
2cc105c ci: enable workspace lint rules (Nick Johnson) 5dcd5fc policy: Remove function local wildcard imports (Tobin C. Harding) 6af27b1 Run the formatter (Tobin C. Harding) 7063e4a Enable use_self lint (Tobin C. Harding) Pull request description: This is Nick's patch from #963 + the `Self` stuff from #944 + a patch on top to remove some of the `use Policy::*` instances. There are some in there still because I can't be bothered right now working out why `Self::` doesn't work everywhere. This is a step in the right direction. ACKs for top commit: apoelstra: ACK 2cc105c; successfully ran local tests Tree-SHA512: e4acaa66acf5a48290e328903e9110916c5ffdd8f45bcbf0a4a77adfdd8401a8749dbc6b7d69076eccaf2823b431fd61951e0e9cf33a6305c9ed073c14b90df6
4 participants
First patch defines the workspace lint rules and enables them in the root package. While I believe the rules could just be defined in the root package directly, might be nice to share them with the fuzz package (and any future packages)?
Closes #959