Self lint and cleanup#965
Conversation
|
Formatting in separate patches to ease review. |
|
I went ahead and poached your patch @nyonson. |
|
g and m aren't even close on any keyboard layout! Will you squash the formatting commits into their parents? ACK 7af8cb9 |
For the For the "no wildcards" commit sure, there's not a ton of benefit in separating that from the formatter. |
|
Everyone knows hard core hackers call it a forgatter, keep up. |
tcharding
force-pushed
the
push-kowuxrvtuxky
branch
from
7af8cb9 to
8ef4be4
Compare
|
Squashed ... which also removed the |
|
@tcharding Could you re-order these commits? Because the first commit (which enables lints but doesn't make them pass) is the tip of #963, my CI system is trying to test it in "tip" mode, which runs clippy, which fails. Rather than re-architecting my system to understand "test this commit as though it was part of #965 and not part of #963", I think it's easier to make this your problem. |
Lol, love it. Can do. |
tcharding
force-pushed
the
push-kowuxrvtuxky
branch
2 times, most recently
from
c40f957 to
3ee46ba
Compare
Tighten up the linting by using `use_self` and fix all warnings. I got claude to do the fixes. It eventually found its way to using cargo clippy --fix --allow-dirty --allow-staged --workspace \ --all-targets --all-features -- -D clippy::use-self FTR this does not enable the lint because for some reason adding this to the manifest doesn't work. ```rust [workspace.lints.clippy] use_self = "warn" ``` I tested this patch using `cargo +$(cat ./nightly-version ) clippy -- -D clippy::use-self`
All these issues were introduced by the `use_self` change. Fixed separately to make review of that change easier since its 12000 lines long.
Remove `use Foo::*` for bringing enum variants into scope.
tcharding
force-pushed
the
push-kowuxrvtuxky
branch
from
3ee46ba to
2cc105c
Compare
|
I thought of this joke the other day but couldn't find a 'master' quote then coincidentally re-read Eric Raymond's seminal (to me anyways) paper on how to be a hacker and it has the quote in it I wanted. So here it is, for your amusement. Poelstra says, "I think it's easier to make this your problem." I drift back to the days of being an apprentice and remember:
Then think, "mad, I'm saying that from now on - I think it's easier to make this your problem." |
4 participants
This is Nick's patch from #963 + the
Selfstuff from #944 + a patch on top to remove some of theuse Policy::*instances. There are some in there still because I can't be bothered right now working out whySelf::doesn't work everywhere. This is a step in the right direction.