Skip to content

[treeplayer] Replace a char array with a string to simplify the cleanup.#22897

Open
hageboeck wants to merge 1 commit into
root-project:masterfrom
hageboeck:treeplayer_replaceString
Open

[treeplayer] Replace a char array with a string to simplify the cleanup.#22897
hageboeck wants to merge 1 commit into
root-project:masterfrom
hageboeck:treeplayer_replaceString

Conversation

@hageboeck

Copy link
Copy Markdown
Member

Many delete[] and strlcpy could be replaced by changing one type, so this seemed like a small improvement.

This was split off from #22817.

@hageboeck hageboeck self-assigned this Jul 23, 2026
@hageboeck
hageboeck requested review from jblomer and pcanal as code owners July 23, 2026 08:17
@hageboeck
hageboeck force-pushed the treeplayer_replaceString branch from 1e62e0c to 458d772 Compare July 23, 2026 08:56

@jblomer jblomer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread tree/treeplayer/src/TSelectorDraw.cxx Outdated
Comment thread tree/treeplayer/src/TSelectorDraw.cxx Outdated
Many delete[] and strlcpy could be replaced by changing one type.

Co-authored-by: Jakob Blomer <jblomer@cern.ch>
@hageboeck
hageboeck force-pushed the treeplayer_replaceString branch from bca8c1a to acd6f1d Compare July 23, 2026 11:58
@github-actions

Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 20h 2m 8s ⏱️
 3 870 tests  3 870 ✅ 0 💤 0 ❌
75 995 runs  75 995 ✅ 0 💤 0 ❌

Results for commit acd6f1d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants