Object auto registration: Next steps#22817
Draft
hageboeck wants to merge 18 commits into
Draft
Conversation
Test Results 19 files 19 suites 2d 20h 37m 56s ⏱️ For more details on these failures, see this check. Results for commit 2a86453. ♻️ This comment has been updated with latest results. |
hageboeck
force-pushed
the
AutoReg_GlobalDefault
branch
2 times, most recently
from
July 22, 2026 17:34
0f0f681 to
08db558
Compare
This was referenced Jul 23, 2026
Fixtures run even when the setup test is not selected, whereas dependencies only have an effect when setup and main test are selected.
Also remove further includes that were unused.
- Remove unused headers. - Use member initialisers to clean up constructors. - Apply clang-tidy/clang-format fixes for member init.
hageboeck
force-pushed
the
AutoReg_GlobalDefault
branch
from
July 23, 2026 11:39
08db558 to
7e74353
Compare
Many delete[] and strlcpy could be replaced by changing one type.
…ory. When TEventLists don't register themselves to gDirectory, TTree::Draw expressions can't fill them. Therefore, a few lists need to be added to gDirectory manually. Once their Draw expressions have run, they are removed again.
The TTree::Draw documentation states that entry lists and event lists are added to gDirectory. To make this fact independent of ROOT 7 mode, explicitly add instances of these classes to gDirectory. Also add a warning when trying to append to an existing list that can't be found in the current directory.
The TTree::Draw documentation states that event and entry lists can be
found in the current directory after Draw(">>entrylist"), so this needs
to work consistently with auto-registration on and off.
When users ask to append to an existing histogram or event list in a TTree::Draw expression, but the histogram/event list is not in the current directory, issue a warning that object->SetDirectory() might have been forgotten.
TEntryList and its derived classes will from here on only register themselves to gDirectory when the thread-local auto-registration is enabled.
Explain that defaults can be set using .rootrc or using environment variables, and how to do this from within the program.
This commit is to test auto-registration=off across all platforms. It will be removed before merging.
hageboeck
force-pushed
the
AutoReg_GlobalDefault
branch
from
July 23, 2026 11:55
7e74353 to
2a86453
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work on disabling auto registration of TEventList / TEntryList
Typically, when working towards disabling the auto-registration of certain classes, there is an opportunity to clean up code and fix tangentially related issues that are encountered on the way. Like for the last auto-registration PR (#18083), these will be split off into smaller chunks that are going to be merged first:
Note that to uncover potential auto-registration problems, ROOT is in ROOT 7 mode while this PR is in draft mode. The commit that globally enables ROOT 7 mode will be removed before merging the actual work for TEventList / TEntryList.
TODOs: