Skip to content

chore(docker): pin Node.js base images to 24.22.1 - #1897

Merged
gugu merged 1 commit into
mainfrom
chore/node-24.22.1-docker
Oct 26, 2026
Merged

gugu merged 1 commit into
mainfrom
chore/node-24.22.1-docker

Conversation

@andrii-shortio-dev

@andrii-shortio-dev andrii-shortio-dev commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Pin every Node.js Docker base image to 24.22.1, the latest security release on Node 24 LTS (released 2026-10-20, per nodejs.org/dist/index.json).
  • frontend/Dockerfile: node:18-alpine (EOL) → node:24.22.1-alpine. The root Dockerfile already builds the frontend on Node 24.
  • rocketadmin-agent/Dockerfile: node:22-slim → node:24.22.1-slim, matching Dockerfile.rocketadmin-agent.
  • Dockerfile, Dockerfile.rocketadmin-agent, autoadmin-ws-server/Dockerfile, test/proxy-mock-api/Dockerfile: floating node:24-* → node:24.22.1-*.

These are exact pins, so future patch releases won't be picked up automatically. Bump them manually or with Dependabot/Renovate.

Test plan

  • CI image builds pass (main, agent, ws-server, frontend)
  • Backend test suite passes under the new image

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated Node.js base images used to build and run the application, agent, and test containers to version 24.22.1. This includes updates from Node.js 18 and 22, as well as earlier 24.x images.

Pin all Node base images to 24.22.1, the latest security release on the
24 LTS line (2026-10-20). Also moves frontend/Dockerfile off EOL Node 18
and rocketadmin-agent/Dockerfile off Node 22 onto 24.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e9099ab8-c4b4-4c11-bce0-bab3b99086c1
Commits

Reviewing files that changed from the base of the PR and between 903c7f4 and f0d25da.

Files selected for processing: 6
  • Dockerfile
  • Dockerfile.rocketadmin-agent
  • autoadmin-ws-server/Dockerfile
  • frontend/Dockerfile
  • rocketadmin-agent/Dockerfile
  • test/proxy-mock-api/Dockerfile

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Walkthrough

Dockerfiles now use Node 24.22.1 base images. The changes update builder and runtime stages across the application, agent, WebSocket server, and proxy mock API images.

Changes: Node base image updates

Layer / File(s) Summary
Update Docker base image references
Dockerfile, Dockerfile.rocketadmin-agent, autoadmin-ws-server/Dockerfile, frontend/Dockerfile, rocketadmin-agent/Dockerfile, test/proxy-mock-api/Dockerfile
Build and runtime stages now use Node 24.22.1 images. The frontend builder uses the public.ecr.aws/docker/library image reference.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: artuomka

Merge Risk: Minimal · up to f0d25

This change pins the Node base images to 24.22.1 across the Dockerfiles, and the frontend image now builds on a Node version its Angular tooling supports. No actionable merge-blocking risk remains. CI image builds should still be run, as the PR's test plan already says.

Pre-merge checks: Passed 6
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: pinning Docker Node.js base images to version 24.22.1.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Security Check Passed The pull request only changes Node.js base-image tags. It replaces floating or older Node versions with 24.22.1 in all changed Node-based Dockerfiles. It does not change application code, permission…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (6 skipped: 6 unsupported.)

Full details: Security Check

Explanation

The pull request only changes Node.js base-image tags. It replaces floating or older Node versions with 24.22.1 in all changed Node-based Dockerfiles. It does not change application code, permissions, exposed ports, commands, dependency installation, or runtime configuration. The change reduces version drift and introduces no evidence of an OWASP-related security regression.

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks each image tag,
Node’s newer number fills the stack.
Slim and Alpine stand in line,
The builder hops; the runtime’s fine.
The Dockerfiles wear pins in time.

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested a review from Artuomka October 26, 2026 13:08
@gugu
gugu merged commit 649c8a2 into main Oct 26, 2026
18 of 19 checks passed
@gugu
gugu deleted the chore/node-24.22.1-docker branch October 26, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants