Skip to content

feat: render cassandra blob columns via binary widget #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gugu merged 1 commit into from
Apr 24, 2026
Merged

feat: render cassandra blob columns via binary widget #1736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...src/app/components/dashboard/db-table-view/db-table-widgets/db-table-widgets.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ export class DbTableWidgetsComponent implements OnInit {
};
// JSON5-formatted default params
public defaultParams = {
Binary: `// No settings required`,
Boolean: `// Display "Yes/No" buttons with configurable options:
// - allow_null: Use "false" to require selection, "true" if field can be left unspecified
// - invert_colors: Swap the color scheme (typically green=Yes, red=No becomes red=Yes, green=No)
Expand Down
3 changes: 3 additions & 0 deletions frontend/src/app/consts/filter-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,9 @@ export const filterTypes = {
ascii: TextFilterComponent,
text: TextFilterComponent,

//binary
blob: BinaryFilterComponent,

list: JsonEditorFilterComponent,
map: JsonEditorFilterComponent,
set: JsonEditorFilterComponent,
Expand Down
3 changes: 3 additions & 0 deletions frontend/src/app/consts/record-edit-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,9 @@ export const recordEditTypes = {
ascii: TextEditComponent,
text: TextEditComponent,

//binary
blob: BinaryEditComponent,

list: JsonEditorEditComponent,
map: JsonEditorEditComponent,
set: JsonEditorEditComponent,
Expand Down
3 changes: 3 additions & 0 deletions frontend/src/app/consts/record-view-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,9 @@ export const recordViewFieldTypes = {
ascii: TextRecordViewComponent,
text: LongTextRecordViewComponent,

//binary
blob: BinaryRecordViewComponent,

list: JsonEditorRecordViewComponent,
map: JsonEditorRecordViewComponent,
set: JsonEditorRecordViewComponent,
Expand Down
3 changes: 3 additions & 0 deletions frontend/src/app/consts/table-display-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,9 @@ export const tableDisplayTypes = {
ascii: TextDisplayComponent,
text: LongTextDisplayComponent,

//binary
blob: BinaryDisplayComponent,

list: JsonEditorDisplayComponent,
map: JsonEditorDisplayComponent,
set: JsonEditorDisplayComponent,
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@
"lodash@>=4.0.0 <=4.17.23": ">=4.18.0",
"lodash@<=4.17.23": ">=4.18.0",
"@nestjs/core@<=11.1.17": ">=11.1.18",
"uuid@<14.0.0": ">=14.0.0"
"uuid@<14.0.0": ">=14.0.0",
"fast-xml-parser@<5.7.0": ">=5.7.0"
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify fast-xml-parser version 5.7.0 exists and check for security advisories

# Check npm registry for version availability
echo "Checking fast-xml-parser versions..."
npm view fast-xml-parser versions --json | jq -r '.[]' | grep -E '^5\.(7|[8-9]|[0-9]{2})\.' | head -10

# Check for security advisories
echo -e "\nChecking security advisories..."
gh api graphql -f query='
{
  securityVulnerabilities(first: 10, ecosystem: NPM, package: "fast-xml-parser") {
    nodes {
      advisory {
        summary
        severity
        publishedAt
      }
      vulnerableVersionRange
      firstPatchedVersion {
        identifier
      }
    }
  }
}'

Repository: rocket-admin/rocketadmin

Length of output: 3072

Document the security advisory in the PR description.

The override correctly enforces fast-xml-parser@>=5.7.0 to address a legitimate MODERATE severity vulnerability: "XMLBuilder: XML Comment and CDATA Injection via Unescaped Delimiters" (affects versions < 5.7.0). The fix is valid and necessary.

However, the PR description should explicitly reference this security advisory. Since the PR's primary objective is Cassandra blob Binary widget support, mentioning the CVE/advisory details will clarify that this dependency upgrade is a separate security fix applied during the audit, not scope creep.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@package.json` at line 33, Update the PR description to explicitly document
the security override for fast-xml-parser by referencing the advisory
(XMLBuilder: XML Comment and CDATA Injection via Unescaped Delimiters), noting
it addresses versions < 5.7.0 and enforces "fast-xml-parser@>=5.7.0" (the
override line in package.json), include the severity (MODERATE), any
CVE/advisory URL if available, and state this dependency upgrade is a separate
security fix applied during the audit rather than part of the Cassandra blob
Binary widget work.

},
"packageExtensions": {
"ibm_db": {
Expand Down
15 changes: 11 additions & 4 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading