feat: render cassandra blob columns via binary widget#1736
Conversation
Map cassandra `blob` to the Binary widget across table display, record view, record edit, and filter type maps — previously cassandra blob columns rendered empty since no default mapping existed. Also add a `Binary` entry to widget defaultParams so the Binary widget type is selectable in table settings without undefined widget_params. Include a fast-xml-parser>=5.7.0 override from pnpm audit --fix. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
📝 WalkthroughWalkthroughAdds support for Cassandra Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Maps Cassandra blob columns to the Binary widget so they render correctly across table display, record view, record edit, and filters, and ensures the Binary widget type is selectable in table settings with non-undefined default params. Also applies a fast-xml-parser>=5.7.0 override and updates the pnpm lockfile accordingly.
Changes:
- Add Cassandra
blob→ Binary component mappings in table display, record view, record edit, and filter type maps. - Add
Binaryto table-widget default parameters to avoidundefinedwidget params when selected. - Add
fast-xml-parser@<5.7.0override and updatepnpm-lock.yamltofast-xml-parser@5.7.1.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Locks fast-xml-parser to 5.7.1 and includes new transitive deps per the security override. |
| package.json | Adds pnpm override enforcing fast-xml-parser>=5.7.0. |
| frontend/src/app/consts/table-display-types.ts | Maps Cassandra blob to BinaryDisplayComponent. |
| frontend/src/app/consts/record-view-types.ts | Maps Cassandra blob to BinaryRecordViewComponent. |
| frontend/src/app/consts/record-edit-types.ts | Maps Cassandra blob to BinaryEditComponent. |
| frontend/src/app/consts/filter-types.ts | Maps Cassandra blob to BinaryFilterComponent. |
| frontend/src/app/components/dashboard/db-table-view/db-table-widgets/db-table-widgets.component.ts | Adds Binary default params so the widget is selectable without undefined params. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
package.json (1)
4-4:⚠️ Potential issue | 🔴 CriticalCritical: Pipeline failure due to duplicate pnpm version specification.
The GitHub Actions workflow specifies
version: 10whilepackage.jsonspecifiespnpm@10.33.0. Remove the version key from the GitHub Action configuration to resolve theERR_PNPM_BAD_PM_VERSIONerror.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` at line 4, The pipeline is failing because package.json declares "packageManager": "pnpm@10.33.0" while the GitHub Actions workflow also sets a conflicting pnpm version (the workflow's version: 10). Fix this by removing the `version:` key from the Actions step that installs pnpm (leave the workflow to use the project's packageManager) or, alternatively, align it exactly with "pnpm@10.33.0"; locate the workflow step that references pnpm `version:` and delete that `version` field so it no longer conflicts with package.json's packageManager.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Line 33: Update the PR description to explicitly document the security
override for fast-xml-parser by referencing the advisory (XMLBuilder: XML
Comment and CDATA Injection via Unescaped Delimiters), noting it addresses
versions < 5.7.0 and enforces "fast-xml-parser@>=5.7.0" (the override line in
package.json), include the severity (MODERATE), any CVE/advisory URL if
available, and state this dependency upgrade is a separate security fix applied
during the audit rather than part of the Cassandra blob Binary widget work.
---
Outside diff comments:
In `@package.json`:
- Line 4: The pipeline is failing because package.json declares
"packageManager": "pnpm@10.33.0" while the GitHub Actions workflow also sets a
conflicting pnpm version (the workflow's version: 10). Fix this by removing the
`version:` key from the Actions step that installs pnpm (leave the workflow to
use the project's packageManager) or, alternatively, align it exactly with
"pnpm@10.33.0"; locate the workflow step that references pnpm `version:` and
delete that `version` field so it no longer conflicts with package.json's
packageManager.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 76086182-bfb6-47f7-aeda-a3baa38f6789
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (6)
frontend/src/app/components/dashboard/db-table-view/db-table-widgets/db-table-widgets.component.tsfrontend/src/app/consts/filter-types.tsfrontend/src/app/consts/record-edit-types.tsfrontend/src/app/consts/record-view-types.tsfrontend/src/app/consts/table-display-types.tspackage.json
| "@nestjs/core@<=11.1.17": ">=11.1.18", | ||
| "uuid@<14.0.0": ">=14.0.0" | ||
| "uuid@<14.0.0": ">=14.0.0", | ||
| "fast-xml-parser@<5.7.0": ">=5.7.0" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify fast-xml-parser version 5.7.0 exists and check for security advisories
# Check npm registry for version availability
echo "Checking fast-xml-parser versions..."
npm view fast-xml-parser versions --json | jq -r '.[]' | grep -E '^5\.(7|[8-9]|[0-9]{2})\.' | head -10
# Check for security advisories
echo -e "\nChecking security advisories..."
gh api graphql -f query='
{
securityVulnerabilities(first: 10, ecosystem: NPM, package: "fast-xml-parser") {
nodes {
advisory {
summary
severity
publishedAt
}
vulnerableVersionRange
firstPatchedVersion {
identifier
}
}
}
}'Repository: rocket-admin/rocketadmin
Length of output: 3072
Document the security advisory in the PR description.
The override correctly enforces fast-xml-parser@>=5.7.0 to address a legitimate MODERATE severity vulnerability: "XMLBuilder: XML Comment and CDATA Injection via Unescaped Delimiters" (affects versions < 5.7.0). The fix is valid and necessary.
However, the PR description should explicitly reference this security advisory. Since the PR's primary objective is Cassandra blob Binary widget support, mentioning the CVE/advisory details will clarify that this dependency upgrade is a separate security fix applied during the audit, not scope creep.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@package.json` at line 33, Update the PR description to explicitly document
the security override for fast-xml-parser by referencing the advisory
(XMLBuilder: XML Comment and CDATA Injection via Unescaped Delimiters), noting
it addresses versions < 5.7.0 and enforces "fast-xml-parser@>=5.7.0" (the
override line in package.json), include the severity (MODERATE), any
CVE/advisory URL if available, and state this dependency upgrade is a separate
security fix applied during the audit rather than part of the Cassandra blob
Binary widget work.
Map cassandra
blobto the Binary widget across table display, record view, record edit, and filter type maps — previously cassandra blob columns rendered empty since no default mapping existed. Also add aBinaryentry to widget defaultParams so the Binary widget type is selectable in table settings without undefined widget_params.Include a fast-xml-parser>=5.7.0 override from pnpm audit --fix.
Summary by CodeRabbit