Skip to content

fix(dashboard): use file URL for dynamic import on Windows #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
richardsongunde wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(dashboard): use file URL for dynamic import on Windows #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bin/rstack-business.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
*/

import { createRequire } from 'node:module';
import { fileURLToPath } from 'node:url';
import { fileURLToPath, pathToFileURL } from 'node:url';
import path from 'node:path';

const __dirname = path.dirname(fileURLToPath(import.meta.url));
Expand Down Expand Up @@ -64,7 +64,7 @@ if (args.includes('--version') || args.includes('-v')) {
}

const serverPath = path.resolve(__dirname, '../src/observability/dashboard/server.js');
import(serverPath).catch((err) => {
import(pathToFileURL(serverPath).href).catch((err) => {
console.error(`[rstack-business] Failed to start: ${err.message}`);
console.error(err);
process.exit(1);
Expand Down
4 changes: 2 additions & 2 deletions bin/rstack-observer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* scripts, and muscle memory land on the single supported dashboard.
*/

import { fileURLToPath } from 'node:url';
import { fileURLToPath, pathToFileURL } from 'node:url';
import path from 'node:path';

const __dirname = path.dirname(fileURLToPath(import.meta.url));
Expand All @@ -23,7 +23,7 @@ for (let i = 0; i < process.argv.length; i++) {

process.stderr.write('[rstack] rstack-observer now opens the unified Business Hub. Use rstack-business for new scripts.\n');

import(serverPath).catch((err) => {
import(pathToFileURL(serverPath).href).catch((err) => {
console.error(`[rstack-observer] Failed to start unified dashboard: ${err.message}`);
console.error(err);
process.exit(1);
Expand Down
Loading