fix(dashboard): use file URL for dynamic import on Windows#63
Open
richardsongunde wants to merge 1 commit into
Open
fix(dashboard): use file URL for dynamic import on Windows#63richardsongunde wants to merge 1 commit into
richardsongunde wants to merge 1 commit into
Conversation
bin/rstack-business.js and bin/rstack-observer.js dynamically import an absolute server path. On Windows that path begins with a drive letter (e.g. 'D:\...'), which Node's ESM loader rejects with ERR_UNSUPPORTED_ESM_URL_SCHEME (protocol 'd:'). Convert the path to a file:// URL via pathToFileURL before import() so the launcher starts on Windows as it already does on POSIX.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Convert the absolute server path to a
file://URL viapathToFileURL(serverPath).hrefbeforeimport()in both launcher entry points.Why
On Windows,
import(serverPath)receives a drive-letter path (e.g.D:\...) which Node's ESM loader rejects withERR_UNSUPPORTED_ESM_URL_SCHEME(protocold:), so the Business Hub / observer never start. POSIX is unaffected.Changes
bin/rstack-business.js: importpathToFileURL, wrap dynamic importbin/rstack-observer.js: same fix (sibling launcher)Testing
node --checkpasses on both filesnode bin/rstack-business.jsnow boots on Windows and serves http://localhost:3008 (verified/api/healthand/return 200)Closes #62