Skip to content

fix: guard delayed drag autoscroll after dispose #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SebTardif wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: guard delayed drag autoscroll after dispose #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions lib/src/_code_selection.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,11 +375,19 @@ class _CodeSelectionGestureDetectorState extends State<_CodeSelectionGestureDete
void _autoScrollWhenDragging() {
final Offset? position = _dragPosition;
Future.delayed(const Duration(milliseconds: 100), (() {
// Widget may have been disposed while the delayed callback was pending.
if (!mounted) {
return;
}
if (_dragPosition == null || position == null) {
return;
}
if (_dragging) {
render.autoScrollWhenDragging(_dragPosition!);
final renderObject = widget.editorKey.currentContext?.findRenderObject();
if (renderObject is! _CodeFieldRender) {
return;
}
renderObject.autoScrollWhenDragging(_dragPosition!);
_extendSelection(_dragPosition!, _SelectionChangedCause.drag);
}
_autoScrollWhenDragging();
Expand Down Expand Up @@ -909,7 +917,12 @@ class _MobileSelectionOverlayController implements _SelectionOverlayController {
if (!_startHandleDragging) {
return;
}
ensureRender.autoScrollWhenDragging(_startHandleDragLastPosition);
// Overlay/controller may outlive the field after dispose.
final renderObject = editorKey.currentContext?.findRenderObject();
if (renderObject is! _CodeFieldRender) {
return;
}
renderObject.autoScrollWhenDragging(_startHandleDragLastPosition);
_handleStartHandleDragUpdate(_startHandleDragLastPosition);
_autoScrollWhenStartHandleDragging();
}));
Expand All @@ -920,7 +933,11 @@ class _MobileSelectionOverlayController implements _SelectionOverlayController {
if (!_endHandleDragging) {
return;
}
ensureRender.autoScrollWhenDragging(_endHandleDragLastPosition);
final renderObject = editorKey.currentContext?.findRenderObject();
if (renderObject is! _CodeFieldRender) {
return;
}
renderObject.autoScrollWhenDragging(_endHandleDragLastPosition);
_handleEndHandleDragUpdate(_endHandleDragLastPosition);
_autoScrollWhenEndHandleDragging();
}));
Expand Down