fix: guard delayed drag autoscroll after dispose#118
Open
SebTardif wants to merge 1 commit into
Open
Conversation
Future.delayed callbacks in selection drag autoscroll can fire after the editor is removed. The non-null cast on findRenderObject then crashes. Check mounted and use a safe typed cast before scrolling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delayed drag autoscroll callbacks can run after the
CodeEditoris disposed. They callrender/ensureRender, which castfindRenderObject()withas _CodeFieldRender. WhencurrentContextis null after dispose, that cast throws and crashes the app.This change:
!mountedin the gesture detector autoscroll loopis! _CodeFieldRendercheck instead of a force cast before callingautoScrollWhenDragging(desktop drag + mobile handle drag paths)Failure scenario
Future.delayed(100ms, ...).as _CodeFieldRenderand crashes.Bug origin
_autoScrollWhenDragginghas usedFuture.delayedsince the selection gesture code was introduced (MegatronKing, 2024-02). The mobile handle paths use the same pattern withensureRender.Related
Test plan
No automated widget test added: this path depends on Flutter render objects and delayed callbacks; the fix is the same null-safe pattern already used elsewhere in
_MobileSelectionOverlayControllerfor optional render lookups.