Skip to content

Delete gutted RCTModuleData class and its dead imports (#59426) #59426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christophpurrer wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −253
Open

Delete gutted RCTModuleData class and its dead imports (#59426) #59426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/react-native/React/Base/RCTBridge.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
#import "RCTInspectorUtils.h"
#import "RCTJSThread.h"
#import "RCTLog.h"
#import "RCTModuleData.h"
#import "RCTPausedInDebuggerOverlayController.h"
#import "RCTPerformanceLogger.h"
#import "RCTReloadCommand.h"
Expand Down
123 changes: 0 additions & 123 deletions packages/react-native/React/Base/RCTModuleData.h
View file
Open in desktop

This file was deleted.

43 changes: 0 additions & 43 deletions packages/react-native/React/Base/RCTModuleData.mm
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/react-native/React/CxxModule/RCTCxxUtils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
#import <Foundation/Foundation.h>

@class RCTBridge;
@class RCTModuleData;

namespace facebook::react {

Expand Down
1 change: 0 additions & 1 deletion packages/react-native/React/CxxModule/RCTCxxUtils.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

#import "RCTCxxUtils.h"

#import <React/RCTModuleData.h>
#import <React/RCTUtils.h>
#import <cxxreact/CxxNativeModule.h>
#import <jsi/jsi.h>
Expand Down
1 change: 0 additions & 1 deletion packages/react-native/React/Modules/RCTUIManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
#import "RCTLayoutAnimation.h"
#import "RCTLayoutAnimationGroup.h"
#import "RCTLog.h"
#import "RCTModuleData.h"
#import "RCTModuleMethod.h"
#import "RCTScrollableProtocol.h"
#import "RCTShadowView.h"
Expand Down
1 change: 0 additions & 1 deletion ...nderer/components/legacyviewmanagerinterop/LegacyViewManagerInteropComponentDescriptor.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include <React/RCTBridgeProxy.h>
#include <React/RCTComponentData.h>
#include <React/RCTEventDispatcher.h>
#include <React/RCTModuleData.h>
#import <react/featureflags/ReactNativeFeatureFlags.h>
#include <react/renderer/components/legacyviewmanagerinterop/LegacyViewManagerInteropState.h>
#include <react/utils/ContextContainer.h>
Expand Down
1 change: 0 additions & 1 deletion ...ct/renderer/components/legacyviewmanagerinterop/RCTLegacyViewManagerInteropCoordinator.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
#include <React/RCTBridgeProxy.h>
#include <React/RCTComponentData.h>
#include <React/RCTEventDispatcherProtocol.h>
#include <React/RCTModuleData.h>
#include <React/RCTModuleMethod.h>
#include <React/RCTUIManager.h>
#include <React/RCTUIManagerUtils.h>
Expand Down
1 change: 0 additions & 1 deletion packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTInstance.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
#import <React/RCTEventDispatcherProtocol.h>
#import <React/RCTLog.h>
#import <React/RCTLogBox.h>
#import <React/RCTModuleData.h>
#import <React/RCTPerformanceLogger.h>
#import <React/RCTRedBox.h>
#import <React/RCTSurfacePresenter.h>
Expand Down
20 changes: 0 additions & 20 deletions scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1349,22 +1349,6 @@ interface RCTModalHostViewComponentView : public RCTViewComponentView <UIAdaptiv
public virtual void presentViewController:animated:completion:(UIViewController* modalViewController, BOOL animated, void(^)(void) completion);
}

interface RCTModuleData : public NSObject <RCTInvalidating> {
public @property (assign) BOOL requiresMainQueueSetup;
public @property (assign, readonly) BOOL hasConstantsToExport;
public @property (assign, readonly) BOOL hasInstance;
public @property (assign, readonly) BOOL implementsBatchDidComplete;
public @property (copy, readonly) NSArray<id<RCTBridgeMethod>>* methods;
public @property (copy, readonly) NSDictionary<NSString*, id<RCTBridgeMethod>>* methodsByName;
public @property (copy, readonly) NSDictionary<NSString*, id>* exportedConstants;
public @property (copy, readonly) NSString* name;
public @property (strong) id<RCTBridgeModule> instance;
public @property (strong, readonly) Class moduleClass;
public @property (strong, readonly) dispatch_queue_t methodQueue;
public @property (weak) id<RCTModuleDataCallInvokerProvider> callInvokerProvider;
public virtual void gatherConstants();
}

interface RCTModuleMethod : public NSObject <RCTBridgeMethod> {
public @property (assign, readonly) Class moduleClass;
public @property (assign, readonly) SEL selector;
Expand Down Expand Up @@ -2793,10 +2777,6 @@ protocol RCTLocalizationProtocol : public NSObject {
protocol RCTModalHostViewViewProtocol : public NSObject {
}

protocol RCTModuleDataCallInvokerProvider : public NSObject {
public virtual RCTCallInvoker* callInvokerForModuleData:(RCTModuleData* moduleData);
}

protocol RCTModuleProvider : public NSObjectNSObject {
public virtual std::shared_ptr<facebook::react::TurboModule> getTurboModule:(const facebook::react::ObjCTurboModule::InitParams& params);
}
Expand Down
20 changes: 0 additions & 20 deletions scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1392,22 +1392,6 @@ interface RCTModalHostViewComponentView : public RCTViewComponentView <UIAdaptiv
public virtual void presentViewController:animated:completion:(UIViewController* modalViewController, BOOL animated, void(^)(void) completion);
}

interface RCTModuleData : public NSObject <RCTInvalidating> {
public @property (assign) BOOL requiresMainQueueSetup;
public @property (assign, readonly) BOOL hasConstantsToExport;
public @property (assign, readonly) BOOL hasInstance;
public @property (assign, readonly) BOOL implementsBatchDidComplete;
public @property (copy, readonly) NSArray<id<RCTBridgeMethod>>* methods;
public @property (copy, readonly) NSDictionary<NSString*, id<RCTBridgeMethod>>* methodsByName;
public @property (copy, readonly) NSDictionary<NSString*, id>* exportedConstants;
public @property (copy, readonly) NSString* name;
public @property (strong) id<RCTBridgeModule> instance;
public @property (strong, readonly) Class moduleClass;
public @property (strong, readonly) dispatch_queue_t methodQueue;
public @property (weak) id<RCTModuleDataCallInvokerProvider> callInvokerProvider;
public virtual void gatherConstants();
}

interface RCTModuleMethod : public NSObject <RCTBridgeMethod> {
public @property (assign, readonly) Class moduleClass;
public @property (assign, readonly) SEL selector;
Expand Down Expand Up @@ -2874,10 +2858,6 @@ protocol RCTLocalizationProtocol : public NSObject {
protocol RCTModalHostViewViewProtocol : public NSObject {
}

protocol RCTModuleDataCallInvokerProvider : public NSObject {
public virtual RCTCallInvoker* callInvokerForModuleData:(RCTModuleData* moduleData);
}

protocol RCTModuleProvider : public NSObjectNSObject {
public virtual std::shared_ptr<facebook::react::TurboModule> getTurboModule:(const facebook::react::ObjCTurboModule::InitParams& params);
}
Expand Down
20 changes: 0 additions & 20 deletions scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1349,22 +1349,6 @@ interface RCTModalHostViewComponentView : public RCTViewComponentView <UIAdaptiv
public virtual void presentViewController:animated:completion:(UIViewController* modalViewController, BOOL animated, void(^)(void) completion);
}

interface RCTModuleData : public NSObject <RCTInvalidating> {
public @property (assign) BOOL requiresMainQueueSetup;
public @property (assign, readonly) BOOL hasConstantsToExport;
public @property (assign, readonly) BOOL hasInstance;
public @property (assign, readonly) BOOL implementsBatchDidComplete;
public @property (copy, readonly) NSArray<id<RCTBridgeMethod>>* methods;
public @property (copy, readonly) NSDictionary<NSString*, id<RCTBridgeMethod>>* methodsByName;
public @property (copy, readonly) NSDictionary<NSString*, id>* exportedConstants;
public @property (copy, readonly) NSString* name;
public @property (strong) id<RCTBridgeModule> instance;
public @property (strong, readonly) Class moduleClass;
public @property (strong, readonly) dispatch_queue_t methodQueue;
public @property (weak) id<RCTModuleDataCallInvokerProvider> callInvokerProvider;
public virtual void gatherConstants();
}

interface RCTModuleMethod : public NSObject <RCTBridgeMethod> {
public @property (assign, readonly) Class moduleClass;
public @property (assign, readonly) SEL selector;
Expand Down Expand Up @@ -2785,10 +2769,6 @@ protocol RCTLocalizationProtocol : public NSObject {
protocol RCTModalHostViewViewProtocol : public NSObject {
}

protocol RCTModuleDataCallInvokerProvider : public NSObject {
public virtual RCTCallInvoker* callInvokerForModuleData:(RCTModuleData* moduleData);
}

protocol RCTModuleProvider : public NSObjectNSObject {
public virtual std::shared_ptr<facebook::react::TurboModule> getTurboModule:(const facebook::react::ObjCTurboModule::InitParams& params);
}
Expand Down
20 changes: 0 additions & 20 deletions scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1349,22 +1349,6 @@ interface RCTModalHostViewComponentView : public RCTViewComponentView <UIAdaptiv
public virtual void presentViewController:animated:completion:(UIViewController* modalViewController, BOOL animated, void(^)(void) completion);
}

interface RCTModuleData : public NSObject <RCTInvalidating> {
public @property (assign) BOOL requiresMainQueueSetup;
public @property (assign, readonly) BOOL hasConstantsToExport;
public @property (assign, readonly) BOOL hasInstance;
public @property (assign, readonly) BOOL implementsBatchDidComplete;
public @property (copy, readonly) NSArray<id<RCTBridgeMethod>>* methods;
public @property (copy, readonly) NSDictionary<NSString*, id<RCTBridgeMethod>>* methodsByName;
public @property (copy, readonly) NSDictionary<NSString*, id>* exportedConstants;
public @property (copy, readonly) NSString* name;
public @property (strong) id<RCTBridgeModule> instance;
public @property (strong, readonly) Class moduleClass;
public @property (strong, readonly) dispatch_queue_t methodQueue;
public @property (weak) id<RCTModuleDataCallInvokerProvider> callInvokerProvider;
public virtual void gatherConstants();
}

interface RCTModuleMethod : public NSObject <RCTBridgeMethod> {
public @property (assign, readonly) Class moduleClass;
public @property (assign, readonly) SEL selector;
Expand Down Expand Up @@ -2793,10 +2777,6 @@ protocol RCTLocalizationProtocol : public NSObject {
protocol RCTModalHostViewViewProtocol : public NSObject {
}

protocol RCTModuleDataCallInvokerProvider : public NSObject {
public virtual RCTCallInvoker* callInvokerForModuleData:(RCTModuleData* moduleData);
}

protocol RCTModuleProvider : public NSObjectNSObject {
public virtual std::shared_ptr<facebook::react::TurboModule> getTurboModule:(const facebook::react::ObjCTurboModule::InitParams& params);
}
Expand Down
Loading