Lifos/fix grant not created

.github/workflows/docs.yaml

@@ -22,12 +22,12 @@ jobs:
         run: cd docs && yarn build
       - name: Deploy docs
         env:
-          GIT_USER: ravisuhag
+          GIT_USER: anshuman-gojek
           GIT_PASS: ${{ secrets.DOCU_RS_TOKEN }}
           DEPLOYMENT_BRANCH: gh-pages
           CURRENT_BRANCH: main
         working-directory: docs
         run: |
-          git config --global user.email "suhag.ravi@gmail.com"
-          git config --global user.name "ravisuhag"
+          git config --global user.email "anshuman.srivastava@gojek.com"
+          git config --global user.name "anshuman-gojek"
           yarn deploy

.github/workflows/release.yaml

@@ -16,7 +16,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v2
         with:
-          go-version: "1.18"
+          go-version: "1.21"
       - name: Login to DockerHub
         uses: docker/login-action@v1
         with:
@@ -27,7 +27,7 @@ jobs:
         uses: goreleaser/goreleaser-action@v2.6.1
         with:
           distribution: goreleaser
-          version: latest
+          version: v1.26.2
           args: --rm-dist
         env:
           GITHUB_TOKEN: ${{ secrets.GO_RELEASER_TOKEN }}

.github/workflows/test.yaml

@@ -9,18 +9,19 @@ jobs:
     steps:
       - uses: actions/setup-go@v2
         with:
-          go-version: "1.18"
+          go-version: "1.21"
       - uses: actions/checkout@v2
         with:
           fetch-depth: 0
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v2
         with:
+          version: v1.59
           skip-go-installation: true
   test:
     strategy:
       matrix:
-        go-version: [1.18.x]
+        go-version: [1.21.x]
         os: [ubuntu-latest]
     runs-on: ${{ matrix.os }}
     steps:

.gitignore

@@ -20,28 +20,9 @@ vendor/
 
 tmp
 
-# git ignore generate files related to gRPC and proto
-/proton/
-/api/proto/odpf/**/*
-
-!/api/proto/odpf/guardian/v1beta1/
-!/api/proto/odpf/guardian/v1beta1/*
-!/api/proto/odpf/guardian/v1beta1/**/*
-
-!/api/proto/odpf/third_party/
-!/api/proto/odpf/third_party/googleapis/
-!/api/proto/odpf/third_party/googleapis/*
-!/api/proto/odpf/third_party/googleapis/**/*
-!/api/proto/odpf/third_party/grpc-gateway/
-!/api/proto/odpf/third_party/grpc-gateway/*
-!/api/proto/odpf/third_party/grpc-gateway/**/*
-
-/third_party/*
-!/third_party/OpenAPI/odpf/guardian/guardian.swagger.json
-
 # guardian
 .guardian.yaml
-guardian
+api/proto/gotocompany/guardian/
 dist/
 
 # editor configurations

.golangci.yaml

@@ -1,14 +1,13 @@
 run:
   timeout: 5m
-  skip-dirs:
-    - api/proto
 output:
-  format: line-number
+  formats:
+    - format: line-number
 linters:
   enable-all: false
   disable-all: true
   enable:
-    - vet
+    - govet
     - goimports
     - thelper
     - tparallel
@@ -25,5 +24,7 @@ linters-settings:
     severity: warning
 issues:
   fix: true
+  exclude-dirs:
+    - api/proto
 severity:
   default-severity: error

.goreleaser.yaml

@@ -12,20 +12,24 @@ builds:
     flags:
       - -a
     ldflags:
-      - -X github.com/odpf/guardian/core.Version={{.Tag}}
-      - -X github.com/odpf/guardian/core.BuildCommit={{.FullCommit}}
-      - -X github.com/odpf/guardian/core.BuildDate={{.Date}}
+      - -X github.com/goto/guardian/core.Version={{.Tag}}
+      - -X github.com/goto/guardian/core.BuildCommit={{.FullCommit}}
+      - -X github.com/goto/guardian/core.BuildDate={{.Date}}
     goos: [darwin, linux, windows]
     goarch: [amd64, 386, arm, arm64]
     env:
       - CGO_ENABLED=0
 archives:
-  - replacements:
-      darwin: macos
-      linux: linux
-      windows: windows
-      386: i386
-      amd64: x86_64
+  - name_template: >-
+      {{- .ProjectName }}_
+      {{- .Version }}_
+      {{- title .Os }}_
+      {{- if eq .Arch "amd64" }}x86_64
+      {{- else if eq .Arch "386" }}i386
+      {{- else if eq .Arch "linux" }}linux
+      {{- else if eq .Arch "windows" }}windows
+      {{- else if eq .Arch "darwin" }}macos
+      {{- else }}{{ .Arch }}{{ end }}
     format_overrides:
       - goos: windows
         format: zip
@@ -47,32 +51,34 @@ dockers:
       - guardian
     dockerfile: Dockerfile
     image_templates:
-      - "docker.io/odpf/{{.ProjectName}}:latest"
-      - "docker.io/odpf/{{.ProjectName}}:{{ .Version }}"
-      - "docker.io/odpf/{{.ProjectName}}:{{ .Tag }}-amd64"
+      - "docker.io/gotocompany/{{.ProjectName}}:latest"
+      - "docker.io/gotocompany/{{.ProjectName}}:{{ .Version }}"
+      - "docker.io/gotocompany/{{.ProjectName}}:{{ .Tag }}-amd64"
 nfpms:
-  - maintainer: ODPF
+  - maintainer: gotocompany
     description: Universal data access tool
-    homepage: https://github.com/odpf/guardian
+    homepage: https://github.com/goto/guardian
     license: Apache 2.0
     formats:
       - deb
       - rpm
-    replacements:
-      darwin: macOS
+    file_name_template: >-
+      {{ .ProjectName }}_
+      {{- title .Os }}_
+      {{- if eq .Arch "darwin" }}macos{{- else }}{{ .Arch }}{{ end }}
 scoop:
   bucket:
-    owner: odpf
+    owner: goto
     name: scoop-bucket
-  homepage: "https://github.com/odpf/guardian"
+  homepage: "https://github.com/goto/guardian"
   description: "Universal data access tool"
   license: Apache 2.0
 brews:
   - name: guardian
-    homepage: "https://github.com/odpf/guardian"
+    homepage: "https://github.com/goto/guardian"
     description: "Universal data access tool"
     tap:
-      owner: odpf
+      owner: goto
       name: homebrew-tap
     license: "Apache 2.0"
     folder: Formula
@@ -81,5 +87,5 @@ brews:
     install: |-
       bin.install "guardian"
     commit_author:
-      name: Ravi Suhag
-      email: suhag.ravi@gmail.com
+      name: github-actions[bot]
+      email: 41898282+github-actions[bot]@users.noreply.github.com

Dockerfile

@@ -5,6 +5,11 @@ RUN apk add openssl
 
 RUN apk add --no-cache ca-certificates && update-ca-certificates
 
+# odps package has an unhandled (panicking) error that requires this pkg to be installed to avoid the panic:
+# https://github.com/aliyun/aliyun-odps-go-sdk/blob/master/odps/restclient/rest_client.go#L171
+# https://github.com/aliyun/aliyun-odps-go-sdk/blob/master/odps/common/http_const.go#L38
+RUN apk --no-cache add tzdata 
+
 RUN curl --output /usr/local/share/ca-certificates/SectigoRSADomainValidationSecureServerCA.crt http://crt.sectigo.com/SectigoRSADomainValidationSecureServerCA.crt
 
 RUN openssl x509 -inform DER -in /usr/local/share/ca-certificates/SectigoRSADomainValidationSecureServerCA.crt -out /usr/local/share/ca-certificates/SectigoRSADomainValidationSecureServerCA.pem -text

Makefile

@@ -1,9 +1,9 @@
-NAME="github.com/odpf/guardian"
+NAME="github.com/goto/guardian"
 COMMIT := $(shell git rev-parse --short HEAD)
 TAG := "$(shell git rev-list --tags --max-count=1)"
 VERSION := "$(shell git describe --tags ${TAG})-next"
 BUILD_DIR=dist
-PROTON_COMMIT := "b9b0deda4ba141084b1741805a1682e26e2a2e74"
+PROTON_COMMIT := "f955ad19a0d18b75c5207b0660e8d345ade496b3"
 
 .PHONY: all build clean test tidy vet proto setup format generate
 
@@ -32,6 +32,10 @@ clean: tidy
 test:
 	go test ./... -race -coverprofile=coverage.out
 
+test-short:
+	@echo "Running short tests by disabling store tests..."
+	go test ./... -race -short -coverprofile=coverage.out
+
 coverage: test
 	@echo "Generating coverage report..."
 	@go tool cover -html=coverage.out
@@ -40,6 +44,8 @@ build:
 	@echo "Building guardian version ${VERSION}..."
 	go build -ldflags "-X ${NAME}/core.Version=${VERSION} -X ${NAME}/core.BuildCommit=${COMMIT}" -o dist/guardian .
 	@echo "Build complete"
+	# tips: how to build from local .proto file
+	# buf generate path/to/file.proto --template buf.gen.yaml
 
 buildr: setup
 	goreleaser --snapshot --skip-publish --rm-dist
@@ -59,19 +65,21 @@ config:
 	@cp internal/server/config.yaml config.yaml
 
 proto:
-	@echo "Generating protobuf from odpf/proton"
-	@echo " [info] make sure correct version of dependencies are installed using 'make install'"
-	@buf generate https://github.com/odpf/proton/archive/${PROTON_COMMIT}.zip#strip_components=1 --template buf.gen.yaml --path odpf/guardian
+	@echo "Generating protobuf from goto/proton"
+	@echo " [info] make sure correct version of dependencies are installed using 'make setup'"
+	@buf generate https://github.com/goto/proton/archive/${PROTON_COMMIT}.zip#strip_components=1 --template buf.gen.yaml --path gotocompany/guardian
 	@echo "Protobuf compilation finished"
 
 setup:
 	@echo "Installing dependencies..."
-	go mod tidy
+	go mod download
 	go get google.golang.org/protobuf/cmd/protoc-gen-go@v1.27.1
 	go get github.com/golang/protobuf/proto@v1.5.2
 	go get github.com/golang/protobuf/protoc-gen-go@v1.5.2
 	go get google.golang.org/grpc@v1.40.0
 	go get google.golang.org/grpc/cmd/protoc-gen-go-grpc@v1.1.0
 	go get github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-grpc-gateway@v2.5.0
 	go get github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2@v2.5.0
-	go get github.com/bufbuild/buf/cmd/buf@v0.54.1
+	go get github.com/bufbuild/buf/cmd/buf@v1.15.1
+	go get github.com/vektra/mockery/v2@v2.40.2
+	go get github.com/golangci/golangci-lint/cmd/golangci-lint@v1.59