Lifos/fix grant not created by lifosmin · Pull Request #402 · raystack/guardian

lifosmin · 2026-05-29T06:34:52Z

No description provided.

* feat: migrate to gotocompany * feat: migrate to gotocompany * feat: change code owners * fix: change user for docs * fix: remove odpf proto * Update Makefile Co-authored-by: Sushmith <6890568+bsushmith@users.noreply.github.com> * Update README.md Co-authored-by: Sushmith <6890568+bsushmith@users.noreply.github.com> * Update README.md Co-authored-by: Sushmith <6890568+bsushmith@users.noreply.github.com> * Update README.md Co-authored-by: Sushmith <6890568+bsushmith@users.noreply.github.com> * fix: test workflow * fix: gitignore * fix: add proto * fix: add proto * chore: remove code owners * ci: fix lint install private * fix: update .goreleaser.yaml maintainer Co-authored-by: Abduh <mabdh@users.noreply.github.com> * fix: private repo workflow --------- Co-authored-by: Abduh <mabdh@users.noreply.github.com> Co-authored-by: Sushmith <6890568+bsushmith@users.noreply.github.com> * chore: update workflow credentials Co-authored-by: Abduh <mabdh@users.noreply.github.com> * chore: remove private repo workaround Co-authored-by: Abduh <mabdh@users.noreply.github.com> * chore: reenable coveralls Co-authored-by: Abduh <mabdh@users.noreply.github.com> * chore: change credentials for brew commit author Co-authored-by: Abduh <mabdh@users.noreply.github.com> * fix: fix salt version * docs: add notice file * chore: delete NOTICE file --------- Co-authored-by: Haveiss <haveiss@users.noreply.github.com> Co-authored-by: Abduh <mabdh@users.noreply.github.com> Co-authored-by: Sushmith <6890568+bsushmith@users.noreply.github.com>

- convert duration to days if possible for slack approval notification

- add pagination support in ListUserApprovals api - add pagination support in ListApprovals api - update buf version

…eps (#8) - send appeal rejection notification for auto rejected steps, which got auto-rejected at appeal creation time

* feat(bigquery): fetch labels for dataset and table resources * refactor: rename var * fix: prevent user from updating Resource.Details["_metadata"] * test: extend test for FetchResources * refactor: simplify labels metadata assignment in dataset and table resource model * refactor(bigquery): use bqApi to fetch datasets and tables to reduce calls to bigquery * refactor(bigquery): fetch tables concurrently * test(bigquery): add unit tests for GetDatasets and GetTables methods in client * refactor: limit active goroutines when fetching datasets * refactor: rename "_metadata" to "__metadata" and store it in a const * refactor: declare var for an if block only

- fetch resources on provider update

- rename default notification template file - add additional ctx information to notifier logs - log failed grant revocations only when there are failures

…sg (#24)

- feat(approval): add appeal_statuses filter for list approvals API - test: add test cases Co-authored-by: Rahmat Hidayat <rahmatramahidayat@gmail.com>

- fix: use mutex locks while fetching resources in errgroup. Without the mutex lock, the append resources is not concurrency safe. So use lock while appending to the resources slice

…rigger (#29) * feat(policy): introduce expression in additional appeal requirement trigger * test(appeal): add test for additional appeal creation using expression * test(policy): add more test cases * chore: update proton commit

- check for errors while casting metabase group permission & collection permission into string - fix incorrect log statement

- If the appeal id is empty or invalid in request, server should return 400 bad request instead of 500 internal server error - fix and add test cases

#33) - allow appeal creation to continue on creator details fetch error - `allow_creator_details_failure` is a flag that lets the appeal creation to continue when the request to the identity provider (Policy.IAM) fails. If this is set to true and request to the identity provider fails (4xx or 5xx), the value of `creator` field in the appeal will be nil. Note: any expression that tries to access `$appeal.creator.*` is still evaluated as usual, it might need to have proper nil checking to avoid accessing nil value.

This reverts commit 801c923.

* feat(grant): add expiration_date_reason and requested_expiration_date fields * feat(appeal): initialize requested_expiration_date and expiration_date_reason when transitioning appeal to grant * feat: introduce job for revoking appeals based on user criteria * docs: update config example * refactor(jobs): add "Type" prefix for job types * fix: uncomment revoke logic * chore: enhance logging * fix: fix jobs config read * refactor: improve function readability

* feat: support oidc authentication in iam http client * refactor: rename auth type and credentials field name

- add variables to approver notification message - update examples for job run command

- bump up expr version to v1.12.5

- use accountID filter to fetch pendingAppeals

…account_type (#51) * feat(approval): support search query and filter by resource type and account_type * feat(approval): add indexes for some filterable/searchable columns * chore: update proton commit * feat: include total count in list approvals result * chore: update proton commit * fix: fix gorm query building order * test: add test cases to ensure grouped condition for "q" * chore: add comment to document the issue

* chore: user goreleaser v1.18.2 * chore: fix release pipeline

* refactor(provider): refactor ListLogEntries * feat: grant dormancy check * fix: read raw config * fix: fix some query logs issue * fix: change time range parameter * feat: send notification to the grants owner * chore: apply suggestions from code review Co-authored-by: sushmith <6890568+bsushmith@users.noreply.github.com> * refactor: reuse slices.UniqueStringSlice * refactor: reuse StructToMap * chore: remove unused lines * chore: enhance error log with provider.URN * chore: add validation for activity config * fix: check required private log viewer permission * test: add test cases for client.ListActivities * test: add test case for CorrelateGrantActivities * fix: mark grant.IsPermanent as false when updating the exp date * chore: fix lint warnings * chore: extract sending notifications from goroutine * chore: log activities summary * chore: log provider_urn as key-value in logger --------- Co-authored-by: sushmith <6890568+bsushmith@users.noreply.github.com>

* feat: accept base64 encoded credentials in policy.IAM config * feat: introduce new field for base64 credentials * chore: enhance logging * fix: add json validation for credentials

* feat:add pagination for list appeal and list grant * feat: add listusergrants * chore: Add testing for listappeal and listgrant * feat:add pagination test for list appeal and list grant * chore: Add testing for offset * chore: made test tables for grant_repo and appeal_repo * chore: Update proto commit makefile * chore: proto buf setup --------- Co-authored-by: Lifosmin Simon <lifosmin.simon@Lifosmin-Simon.local>

* feat: Add filter q, account_type for litAppeals and listGrants and added getTotalCount * chore: added testing for total count * chore: fix testing * chore: fix test total * chore: fix test mock appeal and grant * chore: fix test mock user appeal and grant * chore: fix test coverage * chore: fix test coverage 2 * chore: fix test coverage 3 * chore: resolve comments * test: resolve comments * test: fix testing --------- Co-authored-by: Lifosmin Simon <lifosmin.simon@Lifosmin-Simon.local>

* feat: introduce new resource type "service_account" in gcloud_iam provider * feat: grant and revoke access to service account * test: add test cases for service account provider * refactor: use switch case * chore: user goreleaser v1.18.2 * chore: use goreleaser v1.8.3 * chore: fix release pipeline * fix: fix fetching grantable roles next page token * refactor: remove additional checking * chore: use email as service account resource name * test: add more unit tests for GetResources * test: add more unit tests for Grant and Revoke Access

* feat: enable to populate appeal metadata using header * dev * Update service.go * Update service.go * Update service.go

* feat: enable group account type in gitlab provider * chore: add debug logs --------- Co-authored-by: Lifosmin Simon <lifosmin.simon@gojek.com>

…nt correctly (#276)

* chore:enable gitlab gorup resource creation * chore: enable group sharing * fix * fix * feat --------- Co-authored-by: Lifosmin Simon <lifosmin.simon@gojek.com>

* chore: support add/update approval steps * chore: update proto commit --------- Co-authored-by: Anjali Aggarwal <anjali.aggarwal@gojek.com>

Co-authored-by: Anjali Aggarwal <anjali.aggarwal@gojek.com>

…erGrants (#286) * feat(grant): add exclude_empty_appeal filter to list grants - Add ExcludeEmptyAppeal bool to ListGrantsFilter domain struct - Map ExcludeEmptyAppeal from proto request in ListGrants and ListUserGrants handlers - Add IS NOT NULL condition for appeal_id in grant repository when filter is set - Regenerate proto from proton bearaujus/patch-27 (exclude_empty_appeal proto change) - Update PROTON_COMMIT to 42f0e9df532c6561b05b0f8faeece19628bd6e80 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chore: update proton commit --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* feat(grant): add inactive grant policy scoping for ListGrants - Add InactiveGrantPolicy enum mapping in ListGrants handler - Add scoping fields: InactiveGrantGroupId/Type/ResourceId/ProviderType - Add GenerateExcludedGrantIDsForSmartInactiveGrants to service and interface - Refactor: extract smartExcludedGrantIDs private helper - Add mock and tests for new service method - Regenerate pb.go from proton bearaujus/patch-26 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * dev * Delete guardian.pb.validate.go * Update service.go * dev --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* feat(summary): add summary_labels_v2 faceted search support - Add SummaryLabelsV2 bool to ListAppealsFilter, ListApprovalsFilter, ListGrantsFilter - Add SummaryLabelV2 struct and SummaryLabelsV2/LabelsV2Count fields to SummaryResult - Add generateLabelSummariesV2 function in postgres utils (faceted search per label key) - Wire SummaryLabelsV2 in appeal, approval, and grant repository GenerateSummary - Map SummaryLabelsV2 in ListUserAppeals, ListAppeals, ListUserApprovals, ListApprovals, ListGrants, ListUserGrants handlers - Add mutual exclusion guard: summary_labels and summary_labels_v2 cannot both be true - Update adapter ToSummaryProto to use V2 labels when present (V2 takes priority) - Add TestListGrantsSummaryLabelsValidation tests - Regenerate pb.go from proton bearaujus/patch-25 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * add more docs * dev * Update go.mod * Update grant.go * add unittests * Add unittests * dev --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* feat: onboard optimus provider * fix: do not create replay on grant creation * fix: lint * fix: lint * fix: add backfill request overlap check * fix: code coverage * fix: remove appeal conflict check and add credentials encryption * fix: UUID account type * fix: tests * fix: add end_date in guardian resource spec --------- Co-authored-by: Yash Bhardwaj <yash.bhardwaj@gojek.com>

* feat: add resource details filter to list appeal & grant * Update Makefile

* feat: introduce parallel approvers * feat: parallel approvers * add new field * fix * add approver step --------- Co-authored-by: lifosmin.simon <lifosmin.simon@gojek.com>

* fix: merge additional stages first * fix * fix * fix policy * test fix --------- Co-authored-by: lifosmin.simon <lifosmin.simon@gojek.com>

* feat(shield): create team resource type * test_cases * feat: guardian provider onboard action resource type * fix * feat * feat * feat * fix * check permission * fix * fix * feat(shield): create team resource type * fix: create_team * fix: create_team * fix: create_team * fix: create_team * fix: create_team * Update client.go --------- Co-authored-by: lifosmin.simon <lifosmin.simon@gojek.com>

fix_shield_client Co-authored-by: Lifosmin Simon <lifosmin.simon@gmail.com>

Co-authored-by: Lifosmin Simon <lifosmin.simon@gmail.com>

* chore: single load each table in case batch load fails * dev --------- Co-authored-by: Anjali Aggarwal <anjali.aggarwal@gojek.com> Co-authored-by: bearaujus <haryo.assyafah@gopay.co.id>

coderabbitai · 2026-05-29T06:35:05Z

Important

Review skipped

Too many files!

This PR contains 294 files, which is 144 over the limit of 150.

To get a review, narrow the scope:
• coderabbit review --type committed # exclude uncommitted changes
• coderabbit review --dir # limit to a subdirectory
• coderabbit review --base # compare against a closer base

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fcf7e9ab-3578-43ea-b9cd-ca7f35b04fc7

📥 Commits

Reviewing files that changed from the base of the PR and between faf5807 and 7ec80e9.

⛔ Files ignored due to path filters (6)

api/proto/gotocompany/guardian/v1beta1/guardian.pb.go is excluded by !**/*.pb.go
api/proto/gotocompany/guardian/v1beta1/guardian.pb.gw.go is excluded by !**/*.pb.gw.go
api/proto/gotocompany/guardian/v1beta1/guardian_grpc.pb.go is excluded by !**/*.pb.go
api/proto/odpf/guardian/v1beta1/guardian.pb.go is excluded by !**/*.pb.go
docs/static/img/banner.svg is excluded by !**/*.svg
go.sum is excluded by !**/*.sum

📒 Files selected for processing (294)

.github/CODEOWNERS
.github/workflows/docs.yaml
.github/workflows/release.yaml
.github/workflows/test.yaml
.gitignore
.golangci.yaml
.goreleaser.yaml
Dockerfile
Makefile
README.md
api/handler/v1beta1/activity.go
api/handler/v1beta1/adapter.go
api/handler/v1beta1/adapter_test.go
api/handler/v1beta1/appeal.go
api/handler/v1beta1/appeal_test.go
api/handler/v1beta1/approval.go
api/handler/v1beta1/approval_test.go
api/handler/v1beta1/comment.go
api/handler/v1beta1/comment_test.go
api/handler/v1beta1/grant.go
api/handler/v1beta1/grant_test.go
api/handler/v1beta1/grpc.go
api/handler/v1beta1/grpc_test.go
api/handler/v1beta1/mocks/activityService.go
api/handler/v1beta1/mocks/appealService.go
api/handler/v1beta1/mocks/approvalService.go
api/handler/v1beta1/mocks/grantService.go
api/handler/v1beta1/mocks/policyService.go
api/handler/v1beta1/mocks/providerActivityService.go
api/handler/v1beta1/mocks/providerService.go
api/handler/v1beta1/mocks/resourceService.go
api/handler/v1beta1/policy.go
api/handler/v1beta1/policy_test.go
api/handler/v1beta1/provider.go
api/handler/v1beta1/provider_test.go
api/handler/v1beta1/resource.go
api/handler/v1beta1/resource_test.go
buf.gen.yaml
cli/appeal.go
cli/client.go
cli/config.go
cli/grant.go
cli/help.go
cli/job.go
cli/policy.go
cli/provider.go
cli/resource.go
cli/root.go
cli/server.go
cli/version.go
core/activity/mocks/auditLogger.go
core/activity/mocks/providerService.go
core/activity/mocks/repository.go
core/activity/service.go
core/appeal/activity.go
core/appeal/activity_test.go
core/appeal/comment.go
core/appeal/comment_test.go
core/appeal/errors.go
core/appeal/mocks/approvalService.go
core/appeal/mocks/auditLogger.go
core/appeal/mocks/grantService.go
core/appeal/mocks/iamManager.go
core/appeal/mocks/labelingService.go
core/appeal/mocks/notifier.go
core/appeal/mocks/policyService.go
core/appeal/mocks/providerService.go
core/appeal/mocks/repository.go
core/appeal/mocks/resourceService.go
core/appeal/service.go
core/appeal/service_test.go
core/approval/errors.go
core/approval/mocks/policyService.go
core/approval/mocks/repository.go
core/approval/service.go
core/approval/service_test.go
core/comment/mocks/repository.go
core/comment/service.go
core/comment/service_test.go
core/event/mocks/repository.go
core/event/service.go
core/grant/mocks/appealService.go
core/grant/mocks/auditLogger.go
core/grant/mocks/notifier.go
core/grant/mocks/providerService.go
core/grant/mocks/repository.go
core/grant/mocks/resourceService.go
core/grant/option.go
core/grant/service.go
core/grant/service_test.go
core/labeling/mocks/labeling_service.go
core/labeling/service.go
core/labeling/service_test.go
core/policy/metadata_source.go
core/policy/mocks/auditLogger.go
core/policy/mocks/providerService.go
core/policy/mocks/repository.go
core/policy/mocks/resourceService.go
core/policy/post_appeal_hook.go
core/policy/service.go
core/policy/service_test.go
core/provider/common.go
core/provider/common_test.go
core/provider/errors.go
core/provider/mocks/CompleteClient.go
core/provider/mocks/activityManager.go
core/provider/mocks/assignmentTyper.go
core/provider/mocks/auditLogger.go
core/provider/mocks/client.go
core/provider/mocks/dormancyChecker.go
core/provider/mocks/providerActivityService.go
core/provider/mocks/repository.go
core/provider/mocks/resourceService.go
core/provider/service.go
core/provider/service_test.go
core/report/domain.go
core/report/mocks/notifier.go
core/report/mocks/repository.go
core/report/repository.go
core/report/repository_test.go
core/report/service.go
core/report/service_test.go
core/resource/errors.go
core/resource/mocks/auditLogger.go
core/resource/mocks/repository.go
core/resource/service.go
core/resource/service_test.go
docs/docs/concepts/architecture.md
docs/docs/contribute/architecture.md
docs/docs/contribute/contribution.md
docs/docs/contribute/provider.md
docs/docs/guides/deployment.md
docs/docs/installation.md
docs/docs/introduction.md
docs/docs/providers/gcs.md
docs/docs/reference/api.md
docs/docs/reference/configuration.md
docs/docs/reference/jobs.md
docs/docs/reference/policy.md
docs/docs/roadmap.md
docs/docs/support.md
docs/docs/tour/configuration.md
docs/docusaurus.config.js
domain/activity.go
domain/appeal.go
domain/appeal_activity.go
domain/appeal_test.go
domain/approval.go
domain/approval_test.go
domain/audit.go
domain/audit_log.go
domain/comment.go
domain/grant.go
domain/grant_test.go
domain/labeling_test.go
domain/notifier.go
domain/parallel_approvers_test.go
domain/policy.go
domain/policy_custom_steps.go
domain/policy_custom_steps_test.go
domain/policy_metadata_source.go
domain/policy_metadata_source_test.go
domain/policy_test.go
domain/provider.go
domain/resource.go
domain/summary.go
go.mod
internal/server/config.go
internal/server/config.yaml
internal/server/interceptors.go
internal/server/label_query_parser.go
internal/server/server.go
internal/server/services.go
internal/store/config.go
internal/store/postgres/activity_repository.go
internal/store/postgres/activity_repository_test.go
internal/store/postgres/appeal_repository.go
internal/store/postgres/appeal_repository_test.go
internal/store/postgres/approval_repository.go
internal/store/postgres/approval_repository_test.go
internal/store/postgres/audit_log_repository.go
internal/store/postgres/comment_repository.go
internal/store/postgres/comment_repository_test.go
internal/store/postgres/grant_repository.go
internal/store/postgres/grant_repository_test.go
internal/store/postgres/migrations/000015_add_grant_expiration_info.down.sql
internal/store/postgres/migrations/000015_add_grant_expiration_info.up.sql
internal/store/postgres/migrations/000016_add-indexes-for-approvals-filter.down.sql
internal/store/postgres/migrations/000016_add-indexes-for-approvals-filter.up.sql
internal/store/postgres/migrations/000017_create_grant_unique_index.down.sql
internal/store/postgres/migrations/000017_create_grant_unique_index.up.sql
internal/store/postgres/migrations/000018_add_new_resource_urn_column.down.sql
internal/store/postgres/migrations/000018_add_new_resource_urn_column.up.sql
internal/store/postgres/migrations/000019_create_comments_table.down.sql
internal/store/postgres/migrations/000019_create_comments_table.up.sql
internal/store/postgres/migrations/000020_audit_log_appeal_activities.down.sql
internal/store/postgres/migrations/000020_audit_log_appeal_activities.up.sql
internal/store/postgres/migrations/000021_add_appeal_approval_revision.down.sql
internal/store/postgres/migrations/000021_add_appeal_approval_revision.up.sql
internal/store/postgres/migrations/000022_grant_restore.down.sql
internal/store/postgres/migrations/000022_grant_restore.up.sql
internal/store/postgres/migrations/000023_add_audit_log_id_column..down.sql
internal/store/postgres/migrations/000023_add_audit_log_id_column.up.sql
internal/store/postgres/migrations/000024_add_group_id_group_type_column.down.sql
internal/store/postgres/migrations/000024_add_group_id_group_type_column.up.sql
internal/store/postgres/migrations/000025_add_resource_grouping.down.sql
internal/store/postgres/migrations/000025_add_resource_grouping.up.sql
internal/store/postgres/migrations/000026_add_custom_steps_column.down.sql
internal/store/postgres/migrations/000026_add_custom_steps_column.up.sql
internal/store/postgres/migrations/000027_add_group_index.down.sql
internal/store/postgres/migrations/000027_add_group_index.up.sql
internal/store/postgres/migrations/000028_add_index_owner_status_to_grant.down.sql
internal/store/postgres/migrations/000028_add_index_owner_status_to_grant.up.sql
internal/store/postgres/migrations/000029_add_index_created_by_status_account_id_to_appeal.down.sql
internal/store/postgres/migrations/000029_add_index_created_by_status_account_id_to_appeal.up.sql
internal/store/postgres/migrations/000030_add_approval_columns.down.sql
internal/store/postgres/migrations/000030_add_approval_columns.up.sql
internal/store/postgres/migrations/000031_add_appeal_labels_metadata.down.sql
internal/store/postgres/migrations/000031_add_appeal_labels_metadata.up.sql
internal/store/postgres/migrations/000032_add_approvals_appeal_id.down.sql
internal/store/postgres/migrations/000032_add_approvals_appeal_id.up.sql
internal/store/postgres/migrations/000033_add_stages_to_policies.down.sql
internal/store/postgres/migrations/000033_add_stages_to_policies.up.sql
internal/store/postgres/migrations/000034_add_stage_to_approvals.down.sql
internal/store/postgres/migrations/000034_add_stage_to_approvals.up.sql
internal/store/postgres/model/activity.go
internal/store/postgres/model/appeal.go
internal/store/postgres/model/approval.go
internal/store/postgres/model/approver.go
internal/store/postgres/model/comment.go
internal/store/postgres/model/grant.go
internal/store/postgres/model/policy.go
internal/store/postgres/model/provider.go
internal/store/postgres/model/resource.go
internal/store/postgres/policy_repository.go
internal/store/postgres/policy_repository_test.go
internal/store/postgres/provider_repository.go
internal/store/postgres/provider_repository_test.go
internal/store/postgres/resource_repository.go
internal/store/postgres/resource_repository_test.go
internal/store/postgres/store.go
internal/store/postgres/utils.go
internal/store/postgres/utils_test.go
jobs/fetch_resources.go
jobs/grant_dormancy_check.go
jobs/grant_expiration_reminder.go
jobs/grant_expiration_revoke.go
jobs/handler.go
jobs/jobs.go
jobs/mocks/appealService.go
jobs/mocks/grantService.go
jobs/mocks/providerService.go
jobs/mocks/reportService.go
jobs/pending_approvals_reminder.go
jobs/revoke_grants_by_user_criteria.go
main.go
mocks/BigQueryClient.go
mocks/GrafanaClient.go
mocks/IAMClient.go
mocks/IAMManager.go
mocks/MetabaseClient.go
mocks/Notifier.go
mocks/ProviderClient.go
mocks/ShieldClient.go
mocks/TableauClient.go
mocks/auditLogger.go
pkg/alicatalogapis/client.go
pkg/alicatalogapis/error.go
pkg/alicatalogapis/model.go
pkg/alicatalogapis/role_binding_project.go
pkg/alicatalogapis/role_binding_schema.go
pkg/aliclientmanager/credentials.go
pkg/aliclientmanager/manager.go
pkg/audit/audit.go
pkg/auth/oidc_test.go
pkg/diff/diff.go
pkg/diff/diff_test.go
pkg/evaluator/expression.go
pkg/evaluator/expression_test.go
pkg/gate/client.go
pkg/gate/model.go
pkg/gate/options.go
pkg/http/http.go
pkg/http/http_test.go
pkg/log/logger.go
pkg/log/logger_test.go
pkg/log/mocks/saltLogger.go
pkg/log/noop.go
pkg/opentelemetry/config.go
pkg/opentelemetry/init.go
pkg/opentelemetry/otelhttpclient/annotations.go
pkg/opentelemetry/otelhttpclient/client.go
pkg/opentelemetry/otelhttpclient/http_transport.go
pkg/opentelemetry/otelhttpclient/http_transport_test.go

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

rahmatrhd and others added 30 commits March 14, 2023 16:13

feat: convert duration to days for slack approval notification (#2)

536bd55

- convert duration to days if possible for slack approval notification

feat: add pagination support in ListUserApprovals api (#6)

31b0908

- add pagination support in ListUserApprovals api - add pagination support in ListApprovals api - update buf version

feat(appeal): send appeal rejection notification for auto rejected st…

efc92d3

…eps (#8) - send appeal rejection notification for auto rejected steps, which got auto-rejected at appeal creation time

feat(provider): fetch resources on provider update (#16)

a5e0740

- fetch resources on provider update

fix: rename default notification template file (#21)

93e2973

- rename default notification template file - add additional ctx information to notifier logs - log failed grant revocations only when there are failures

feat: add formatted expiration_date variable to expiration reminder m…

3c948f9

…sg (#24)

chore: add labels to slack notifier logs (#26)

b2aea85

feat(approval): add appeal_statuses filter for list approvals API (#25)

3c37a41

- feat(approval): add appeal_statuses filter for list approvals API - test: add test cases Co-authored-by: Rahmat Hidayat <rahmatramahidayat@gmail.com>

fix: use mutex locks while fetching resources in errgroup (#28)

2f1b5bf

- fix: use mutex locks while fetching resources in errgroup. Without the mutex lock, the append resources is not concurrency safe. So use lock while appending to the resources slice

fix(policy): return error when approvers evaluation returns nil (#32)

8dd8a7c

fix: check for errors while casting metabase group permission (#36)

a68562f

- check for errors while casting metabase group permission & collection permission into string - fix incorrect log statement

fix: send proper error code in case of bad request (#38)

e115c98

- If the appeal id is empty or invalid in request, server should return 400 bad request instead of 500 internal server error - fix and add test cases

chore: bump up expr version to v1.12.5

801c923

Revert "chore: bump up expr version to v1.12.5"

e99ff1e

This reverts commit 801c923.

feat: support google idtoken authentication in iam http client (#43)

30d1f9f

* feat: support oidc authentication in iam http client * refactor: rename auth type and credentials field name

feat(appeal): add variables to approver notification message (#46)

3a71e10

- add variables to approver notification message - update examples for job run command

chore: bump up expr version to v1.12.5 (#44)

35c97d2

- bump up expr version to v1.12.5

feat(appeal): use accountID filter to fetch pendingAppeals (#53)

5b691c7

- use accountID filter to fetch pendingAppeals

fix: fix goreleaser action (#59)

46a0e05

* chore: user goreleaser v1.18.2 * chore: fix release pipeline

feat: accept base64 encoded credentials in policy.IAM config (#61)

ad1350e

* feat: accept base64 encoded credentials in policy.IAM config * feat: introduce new field for base64 credentials * chore: enhance logging * fix: add json validation for credentials

bearaujus and others added 24 commits February 13, 2026 20:24

feat: enable to populate appeal metadata using header (#272)

3a7e6fe

* feat: enable to populate appeal metadata using header * dev * Update service.go * Update service.go * Update service.go

feat: enable group account type in gitlab provider (#273)

0d7160d

* feat: enable group account type in gitlab provider * chore: add debug logs --------- Co-authored-by: Lifosmin Simon <lifosmin.simon@gojek.com>

fix: preserve group_id and group_type on appeal patch to populate gra…

625ec7f

…nt correctly (#276)

chore:enable gitlab gorup resource creation (#278)

dcd494c

* chore:enable gitlab gorup resource creation * chore: enable group sharing * fix * fix * feat --------- Co-authored-by: Lifosmin Simon <lifosmin.simon@gojek.com>

chore: support add/update approval steps (#277)

592264a

* chore: support add/update approval steps * chore: update proto commit --------- Co-authored-by: Anjali Aggarwal <anjali.aggarwal@gojek.com>

chore: ignore 409 error (#279)

0a98975

Co-authored-by: Anjali Aggarwal <anjali.aggarwal@gojek.com>

chore: [maxcompute] add config to fetch owner detail (#282)

71f72aa

Co-authored-by: Anjali Aggarwal <anjali.aggarwal@gojek.com>

feat: add support to prioritize search by exact match first (#285)

8e4b276

feat: implement bot specific package (#283)

9d50888

fix: access revocation error for AliCloudSSO (#291)

8c2ac76

feat: add resource details filter to list appeal & grant (#290)

8bb43da

* feat: add resource details filter to list appeal & grant * Update Makefile

feat: send notification if account id is valid email (#293)

a11291c

feat: introduce parallel approvers (#294)

0540843

* feat: introduce parallel approvers * feat: parallel approvers * add new field * fix * add approver step --------- Co-authored-by: lifosmin.simon <lifosmin.simon@gojek.com>

fix: merge additional stages first (#296)

b433832

* fix: merge additional stages first * fix * fix * fix policy * test fix --------- Co-authored-by: lifosmin.simon <lifosmin.simon@gojek.com>

fix: shield client cache error (#299)

2ba565a

fix_shield_client Co-authored-by: Lifosmin Simon <lifosmin.simon@gmail.com>

fix: phantom approved appeal (#300)

087a59e

Co-authored-by: Lifosmin Simon <lifosmin.simon@gmail.com>

fix: check permission logic (#301)

471cddf

Co-authored-by: Lifosmin Simon <lifosmin.simon@gmail.com>

chore: single load each table in case batch load fails (#302)

f6b45e7

* chore: single load each table in case batch load fails * dev --------- Co-authored-by: Anjali Aggarwal <anjali.aggarwal@gojek.com> Co-authored-by: bearaujus <haryo.assyafah@gopay.co.id>

fix: appeal is approved when grant is not created

7ec80e9

lifosmin requested review from AkarshSatija, bsushmith, mabdh, rahmatrhd and ravisuhag as code owners May 29, 2026 06:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lifos/fix grant not created#402

Lifos/fix grant not created#402
lifosmin wants to merge 218 commits into
raystack:mainfrom
goto:lifos/fix_grant_not_created

lifosmin commented May 29, 2026

Uh oh!

coderabbitai Bot commented May 29, 2026

Review skipped

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Conversation

lifosmin commented May 29, 2026

Uh oh!

coderabbitai Bot commented May 29, 2026

Review skipped

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants