feat: clearer fatal error messages for missing API keys and images#5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Improves the top-level failure messages in
main.pyso users get an actionable line instead of a terse or leaky one, and standardizes the prefix.API keys — the
autopath previously printed justCRITICAL: No API key found.with no hint about what to set. It now names all three env vars:The explicit-provider path names the specific missing var and the fix:
Missing image — the generic handler used to print the raw OS error (
FATAL: [Errno 2] No such file or directory: 'x.png'). A dedicatedFileNotFoundErrorhandler now prints a clean line:Prefix — standardized
CRITICAL:/FATAL:to a singleError:prefix, matching theError: ...voice already used by the argparse validation incli.py.Notes
The image ordering fix (validating before the output directory tree is created) is the follow-up task and lands in a separate PR; this one is message-quality only.
Tests
New
test_main.pycovers the no-key and missing-key error paths (message names the vars, exit code 1,Error:prefix) plus provider-priority and explicit-model resolution. Full suite: 361 passed.