feat: validate input image before creating output dirs#6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Previously
run_vector_searchcalledstorage.initialize()(which creates the<name>/runs/<timestamp>/nodes/output tree) before loading the reference image. A missing or corrupt input therefore left an empty project directory behind on every failed invocation.Now the image is loaded and validated first;
storage.initialize()only runs once the input is known-good. On failure, nothing is written to disk._load_imageis also hardened to distinguish the two failure modes:FileNotFoundError(rendered bymain.pyasError: input image not found: <path>)ValueError: input image could not be read as an image: <path> (...)(rendered as a cleanError:line)Together with PR #5 this closes the missing-image handling: clean message and no stray directories.
Tests
Added two fast tests (no LLM/workers reached, so unmarked) asserting a missing path raises
FileNotFoundErrorand a corrupt file raisesValueError, and that in both casesstorage.project_diris never created. Full suite: 363 passed.