Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SplineFit.stochastic_downsample_interpolation()defaults to normalized time, but its local rejection checks and error diagnostics evaluate the fitted spline with the original timestamps. For a straight trajectory timestamped from 10 to 20, both modes retain all five knots and report a position error of 190 despite exact interpolation at corresponding times.Use the same timestamp-to-spline mapping for local candidate checks and public error diagnostics. Unnormalized fits keep their original time domain, and repeated fits update that choice. The docstring now states the returned spline's domain and correctly describes the returned indices as retained knots.
Validation, CPU/macOS arm64:
This does not change derivative time scaling or turn local rejection checks into a global error guarantee. Other platform matrices, documentation builds and hosted CI were not run locally.
Implementation and independent local review were performed by separate Codex agents.