refactor: theme steering initial pass - #609
Open
emrberk wants to merge 12 commits into
Open
Conversation
WIP theme pass: compress the light elevation ramp, quiet shadows, and rebind hover/focus/selection off brand so crimson stays on tabs, notebook identity, and primary actions. Co-authored-by: Cursor <cursoragent@cursor.com>
Record the remaining palette and binding decisions in THEME-STEERING.md and apply them: status chips, Enabled/Validated, form SelectMenu, and the leftover light chrome leftover from the first lift. Co-authored-by: Cursor <cursoragent@cursor.com>
Retune pink and danger roles and rebind latches, tooltips, dropdown shadows, and result-grid type so light chrome matches Figma without new tokens. Co-authored-by: Cursor <cursoragent@cursor.com>
Light provider-tab hover sits lighter than the selected well. Result-grid selection uses a double hover wash and info cell chrome without retuning the shared gridSelection token. Co-authored-by: Cursor <cursoragent@cursor.com>
Light metrics calendar flips enabled/disabled wells and keeps selected dates inverse. Monitoring count pills match Figma geometry with the quieter 32% stroke. Table and column glyphs settle on contentPrimary. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
Web Console deploy preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the theme steering pass from the fork branch behind #607 onto a branch in this repo, and adds the follow-ups from review.
Supersedes #607. Original work by @zacknelson.
What this changes
A light/dark theme pass across the console: palette retunes, accent → neutral interaction colours, a reworked shadow ramp, focus rings routed through a shared
statusInfoFocushelper, and per-mode surfaces for the chrome that needed them.Surfaces touched: notebook and SQL editor chrome, schema tree, table details drawer, result grid, MCP pair popover and footer pill, AI chat window, top bar, drawers, calendar, and the shared
Badge/Switch/SegmentedControl/SelectMenuprimitives.Follow-ups added on top of #607
MCP footer pill
borderStrongto match the version badge beside itstatusInfo) rather than magenta, matching the popover row for the same messageMCP pair popover
Schema tree
Notebook
Theme hygiene
yarn lint:colorspasses again. It failed on the fork branch with 10 hardcoded colour literals; each moved intosrc/theme/index.tsor now derives viawithAlpha, with pixel-identical output verified by compositing before/afterinteractionSelected,controlTrackRest,controlTrackStrokecontentObject,controlKnob,gridFocus,interactionAccentHover,statusWarningSurfaceHover. Verified unreferenced across TS, SCSS, rawvar(--qdb-color-*)and dynamic lookupssrc/components/Selectdeleted. The custom provider modal was its last consumer and now usesSelectMenuControl, the dropdown every other surface already usedVerification
yarn typecheck,yarn build,yarn lint,lint:colorsall pass. 1987 unit tests pass. Schema tree, MCP popover, and grid selection checked in the running console in both themes.