Skip to content

WIP: lift light surfaces and neutralize chrome hover/focus - #607

Closed
zacknelson wants to merge 7 commits into
questdb:mainfrom
zacknelson:wip/theme-steering-initial-pass
Closed

WIP: lift light surfaces and neutralize chrome hover/focus#607
zacknelson wants to merge 7 commits into
questdb:mainfrom
zacknelson:wip/theme-steering-initial-pass

Conversation

@zacknelson

Copy link
Copy Markdown

Summary

  • Initial theme steering pass for Emre to glance at. Light surfaces are lifted and the elevation ramp is compressed; light shadows are quieter; content sidebars sit on surfaceRaised.
  • Brand crimson is pulled off chrome jobs (field focus, list hover, keyboard outlines, search, dropdown open state, grid hover/selection/resize, column names). Tabs, notebook cell focus, notebook title glyphs, AI composer, and login stay branded.
  • Decision log is in THEME-STEERING.md (status: applied locally). THEMING.md is untouched.

This is still WIP — checkboxes/switches and a few leftover brand bindings are deferred, and palette values will keep moving.

Test plan

  • Light mode: notebook, SQL editor, details drawer, schema tree, editor search, result grid (headers, row hover, selection, column resize)
  • Dark mode glance: same surfaces still read; grid selection/focus ring still visible
  • Confirm branded leftovers still look intentional: tab underlines, notebook cell ring, notebook glyph, AI composer, login, SelectMenu checkmarks
  • Keyboard focus rings are slate (borderStrong), not crimson

Made with Cursor

zacknelson and others added 7 commits September 1, 2026 18:19
WIP theme pass: compress the light elevation ramp, quiet shadows, and
rebind hover/focus/selection off brand so crimson stays on tabs, notebook
identity, and primary actions.

Co-authored-by: Cursor <cursoragent@cursor.com>
Record the remaining palette and binding decisions in THEME-STEERING.md and apply them: status chips, Enabled/Validated, form SelectMenu, and the leftover light chrome leftover from the first lift.

Co-authored-by: Cursor <cursoragent@cursor.com>
Retune pink and danger roles and rebind latches, tooltips, dropdown shadows, and result-grid type so light chrome matches Figma without new tokens.

Co-authored-by: Cursor <cursoragent@cursor.com>
Light provider-tab hover sits lighter than the selected well. Result-grid selection uses a double hover wash and info cell chrome without retuning the shared gridSelection token.

Co-authored-by: Cursor <cursoragent@cursor.com>
Light metrics calendar flips enabled/disabled wells and keeps selected dates inverse. Monitoring count pills match Figma geometry with the quieter 32% stroke. Table and column glyphs settle on contentPrimary.

Co-authored-by: Cursor <cursoragent@cursor.com>
@emrberk

emrberk commented Sep 8, 2026

Copy link
Copy Markdown
Member

Merged into #609 and ran workflows. Closing this one.

@emrberk emrberk closed this Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants