Fix CI step swallowing quarto list tools errors#14341
Merged
Conversation
The 'Verify quarto list tools does not show chromium' step runs under bash -e (errexit). If quarto list tools exits non-zero (e.g. transient network failure in latestRelease()), the script dies at the command substitution before echo prints any output — leaving zero diagnostics. Use set +e around the command and check the exit code separately, matching the pattern already used by the install and update steps in the same workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Verify quarto list tools does not show chromium" step in
test-install.yml runs under
bash -e(errexit). Ifquarto list toolsexits non-zero — e.g. a transient network failure in one of the
latestRelease()calls — the script dies at the command substitutionbefore
echo "$output"runs, leaving zero diagnostics in the CI log.This is what happened in https://github.com/quarto-dev/quarto-cli/actions/runs/24194985703/job/70622305236
(macOS-only, same code passed on the PR run minutes earlier).
Fix
Use
set +earound the command and check the exit code separately —matching the pattern already used by the install and update steps in
the same workflow.
Test plan
quarto list toolscrashes again, the log will now show the actualerror output before failing