Audio: fix/update record-playback test to use shared recorded directory#367
Audio: fix/update record-playback test to use shared recorded directory#367nitinn22 wants to merge 1 commit intoqualcomm-linux:mainfrom
Conversation
Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/run.sh
Outdated
Show resolved
Hide resolved
Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/Audio_Record_Playback.yaml
Outdated
Show resolved
Hide resolved
| @@ -21,6 +22,26 @@ run: | |||
| steps: | |||
| - REPO_PATH="$PWD" | |||
| - cd Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/ | |||
There was a problem hiding this comment.
Please use the repo-standard path form here:
- REPO_PATH="$PWD"
- cd "$REPO_PATH/Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback"
The current relative cd Runner/... form is not aligned with the usual test definition pattern.
Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/Audio_Record_Playback.yaml
Outdated
Show resolved
Hide resolved
Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/Audio_Record_Playback.yaml
Outdated
Show resolved
Hide resolved
Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/Audio_Record_Playback.yaml
Outdated
Show resolved
Hide resolved
Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/Audio_Record_Playback.yaml
Outdated
Show resolved
Hide resolved
Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/run.sh
Outdated
Show resolved
Hide resolved
Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/run.sh
Outdated
Show resolved
Hide resolved
Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/run.sh
Outdated
Show resolved
Hide resolved
|
@nitinn22 I would suggest squashing the commits for cleaner history |
Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/README.md
Outdated
Show resolved
Hide resolved
- Use common recorded directory across audio tests - Update run.sh and YAML for consistent folder handling - Allow individual test execution - Address review feedback# This is the 1st commit message: Audio: fix/update record‑playback test to use shared recorded directory Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com> addressed comments related to making common util for folder handling for video and audio Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com> added individual test case run possibility for audio suite Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com> Modified yaml file to handle common directory structure for files Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com> Modified run sh file to handle common dir Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com> Modified Audio scripts based on comments received Signed-off-by: nitinn <nitinn@qti.qualcomm.com> audio: address final review comments Signed-off-by: nitinn <nitinn@qti.qualcomm.com>
nitinn22
force-pushed
the
feature/audio-record-playback-fix-clean
branch
from
5a40b13 to
37ac48e
Compare
smuppand
left a comment
smuppand
left a comment
There was a problem hiding this comment.
Only the three README fixes are still outstanding. Everything else looks fine.
| 4. **Recording phase (ENCODE - 4 tests)**: | ||
| - **audiotestsrc tests**: Generates sine wave at 440Hz, encodes to WAV/FLAC | ||
| - **pulsesrc tests**: Captures from hardware audio input, encodes to WAV/FLAC | ||
| - Saves recorded files to `logs/Audio_Record_Playback/recorded/` |
There was a problem hiding this comment.
This line is now inaccurate:
Saves recorded files to logs/Audio_Record_Playback/recorded/
With the current runner, recorded artifacts may go to the shared directory via AUDIO_SHARED_RECORDED_DIR / gstreamer_shared_recorded_dir(), and logs/.../recorded/ is only the local fallback. Please update this line so it matches the actual runtime behavior.
| - **Playback**: Pipeline completes successfully with exit code 0 (clean completion) | ||
| - **Note**: Timeout (exit code 124) or termination (exit code 143) are treated as **FAIL** for controlled-duration recordings |
There was a problem hiding this comment.
This wording no longer matches the implementation:
Timeout (exit code 124) or termination (exit code 143) are treated as FAIL for controlled-duration recordings
In the current run.sh, the pulsesrc record path does not fail solely on timeout/termination; it validates the log and then passes if the recorded file exists and is large enough. Please align the README with the actual behavior.
| - `SKIP` - No tests executed or all skipped | ||
| - Test summary is logged showing pass/fail/skip counts | ||
| - Individual test logs are available in `logs/Audio_Record_Playback/` | ||
| - Recorded files are preserved in `logs/Audio_Record_Playback/recorded/` for debugging |
There was a problem hiding this comment.
This line should be updated:
Recorded files are preserved in logs/Audio_Record_Playback/recorded/ for debugging
That is only the local fallback now. In CI/LAVA runs, recorded artifacts may be placed in the shared recorded directory instead. Please make this note consistent with the new shared-artifact behavior documented above.
2 participants
Scope
Audio Record / Playback test updates only.
Changes
Audio_Record_Playback.yamlto use shared recorded directoryrun.shfor consistent record/playback handlingNotes
Validation