Modified Audio scripts based on comments received

Signed-off-by: nitinn <nitinn@qti.qualcomm.com>

Author: nitinn22

Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/Audio_Record_Playback.yaml

@@ -5,7 +5,8 @@ metadata:
     Audio record/playback validation using GStreamer (gst-launch-1.0).
     Tests 10 scenarios: 4 encode (2 audiotestsrc + 2 pulsesrc) + 6 decode (4 playback + 2 OGG/MP3).
     Supports WAV, FLAC, OGG, and MP3 formats with both synthetic audio (audiotestsrc) and hardware capture (pulsesrc).
-    Duration controlled via AUDIO_DURATION (default 10s): audiotestsrc uses num-buffers, pulsesrc uses timeout.
+    Duration controlled via AUDIO_DURATION (default 10s): audiotestsrc uses num-buffers calculated after argument parsing, pulsesrc uses timeout.
+    Uses AUDIO_SHARED_RECORDED_DIR for shared artifact storage across test runs.
   os:
     - linux
   scope:
@@ -21,27 +22,8 @@ params:
 run:
   steps:
     - REPO_PATH="$PWD"
-    - cd Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/
-    - |
-      # Set shared directory to a fixed location outside test-specific paths
-      # This ensures all tests (regardless of LAVA test number) use the same directory
-      if [ -d "/home" ]; then
-        # LAVA environment: use /home/shared
-        AUDIO_SHARED_ENCODE_DIR="/home/shared/audio-record-playback"
-      else
-        # Local/non-LAVA: use standard shared path
-        AUDIO_SHARED_ENCODE_DIR="${REPO_PATH%%/tests/*}/shared/audio-record-playback"
-      fi
-      mkdir -p "$AUDIO_SHARED_ENCODE_DIR" || true
-      export AUDIO_SHARED_ENCODE_DIR
-    - export AUDIO_TEST_MODE AUDIO_TEST_NAME AUDIO_FORMATS AUDIO_DURATION AUDIO_GST_DEBUG
-    - |
-      # Build command based on whether test-name is specified
-      if [ -n "${AUDIO_TEST_NAME}" ]; then
-        # Individual test mode
-        ./run.sh --test-name "${AUDIO_TEST_NAME}" --duration "${AUDIO_DURATION}" --gst-debug "${AUDIO_GST_DEBUG}" || true
-      else
-        # Grouped test mode (original behavior)
-        ./run.sh --mode "${AUDIO_TEST_MODE}" --formats "${AUDIO_FORMATS}" --duration "${AUDIO_DURATION}" --gst-debug "${AUDIO_GST_DEBUG}" || true
-      fi
+    - cd "$REPO_PATH/Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback"
+    - AUDIO_SHARED_RECORDED_DIR="${REPO_PATH%%/tests/*}/shared/audio-record-playback"
+    - export REPO_PATH AUDIO_SHARED_RECORDED_DIR AUDIO_TEST_MODE AUDIO_TEST_NAME AUDIO_FORMATS AUDIO_DURATION AUDIO_GST_DEBUG
+    - ./run.sh || true
     - $REPO_PATH/Runner/utils/send-to-lava.sh Audio_Record_Playback.res

Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/README.md

@@ -537,14 +537,19 @@ fi
 The test supports these environment variables (can be set in LAVA job definition):
 
 - `AUDIO_TEST_MODE` - Test mode (all/record/playback) (default: all)
+- `AUDIO_TEST_NAME` - Individual test name for single test execution (optional)
 - `AUDIO_FORMATS` - Comma-separated format list (default: `wav,flac`)
 - `AUDIO_DURATION` - Recording duration in seconds (default: 10)
 - `RUNTIMESEC` - Alternative to AUDIO_DURATION (for backward compatibility)
 - `AUDIO_GST_DEBUG` - GStreamer debug level (default: 2)
 - `GST_DEBUG_LEVEL` - Alternative to AUDIO_GST_DEBUG
+- `AUDIO_SHARED_RECORDED_DIR` - Shared directory for recorded audio artifacts (optional)
+- `REPO_PATH` - Repository root path (set by YAML, used for path resolution)
 
 **Priority order for duration**: `AUDIO_DURATION` > `RUNTIMESEC` > default (10)
 
+**Shared Artifact Directory**: The test uses `AUDIO_SHARED_RECORDED_DIR` to store recorded audio files in a shared location across multiple test runs. If not set, the test will automatically determine the appropriate directory based on the environment (LAVA vs local).
+
 ### Test Counting
 
 - **Total tests**: 10 (when running with default wav,flac formats in all mode)

Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/run.sh

@@ -47,26 +47,6 @@ OUTDIR="$LOG_DIR/$TESTNAME"
 GST_LOG="$OUTDIR/gst.log"
 DMESG_DIR="$OUTDIR/dmesg"
 
-# Use the shared recorded directory if AUDIO_SHARED_ENCODE_DIR is set; otherwise use function or default.
-if [ -n "${AUDIO_SHARED_ENCODE_DIR:-}" ]; then
-    RECORDED_DIR="$AUDIO_SHARED_ENCODE_DIR"
-elif command -v gstreamer_shared_recorded_dir >/dev/null 2>&1; then
-    RECORDED_DIR="$(gstreamer_shared_recorded_dir "$SCRIPT_DIR" "$OUTDIR")"
-else
-    RECORDED_DIR="$OUTDIR/recorded"
-fi
-
-if ! mkdir -p "$OUTDIR" "$DMESG_DIR" "$RECORDED_DIR"; then
-  log_error "Failed to create required directories:"
-  log_error "  OUTDIR=$OUTDIR"
-  log_error "  DMESG_DIR=$DMESG_DIR"
-  log_error "  RECORDED_DIR=$RECORDED_DIR"
-  echo "$TESTNAME FAIL" >"$RES_FILE" 2>/dev/null || true
-  exit 0
-fi
-: >"$RES_FILE"
-: >"$GST_LOG"
- 
 INIT_ENV=""
 SEARCH="$SCRIPT_DIR"
 while [ "$SEARCH" != "/" ]; do
@@ -95,6 +75,46 @@ fi
 # shellcheck disable=SC1091
 . "$TOOLS/lib_gstreamer.sh"
 
+# Create required directories now that log functions are available
+if ! mkdir -p "$OUTDIR" "$DMESG_DIR"; then
+  log_error "Failed to create required directories:"
+  log_error "  OUTDIR=$OUTDIR"
+  log_error "  DMESG_DIR=$DMESG_DIR"
+  echo "$TESTNAME FAIL" >"$RES_FILE" 2>/dev/null || true
+  exit 0
+fi
+: >"$RES_FILE"
+: >"$GST_LOG"
+
+# -------------------- Set up shared recorded directory --------------------
+# Set shared directory to a fixed location outside test-specific paths
+# This ensures all tests (regardless of LAVA test number) use the same directory
+if [ -z "${AUDIO_SHARED_RECORDED_DIR:-}" ]; then
+  if [ -d "/home" ]; then
+    # LAVA environment: use /home/shared
+    AUDIO_SHARED_RECORDED_DIR="/home/shared/audio-record-playback"
+  else
+    # Local/non-LAVA: use standard shared path
+    AUDIO_SHARED_RECORDED_DIR="${REPO_PATH%%/tests/*}/shared/audio-record-playback"
+  fi
+fi
+
+# Use the shared recorded directory if AUDIO_SHARED_RECORDED_DIR is set; otherwise use function or default.
+if [ -n "${AUDIO_SHARED_RECORDED_DIR:-}" ]; then
+    RECORDED_DIR="$AUDIO_SHARED_RECORDED_DIR"
+elif command -v gstreamer_shared_recorded_dir >/dev/null 2>&1; then
+    RECORDED_DIR="$(gstreamer_shared_recorded_dir "$SCRIPT_DIR" "$OUTDIR")"
+else
+    RECORDED_DIR="$OUTDIR/recorded"
+fi
+
+# Create the recorded directory
+if ! mkdir -p "$RECORDED_DIR"; then
+  log_error "Failed to create recorded directory: $RECORDED_DIR"
+  echo "$TESTNAME FAIL" >"$RES_FILE"
+  exit 0
+fi
+
 result="FAIL"
 reason="unknown"
 pass_count=0
@@ -111,11 +131,6 @@ gstDebugLevel="${AUDIO_GST_DEBUG:-${GST_DEBUG_LEVEL:-2}}"
 clipUrl="${AUDIO_CLIP_URL:-https://github.com/qualcomm-linux/qcom-linux-testkit/releases/download/GST-Audio-Files-v1.0/audio_clips_gst.tar.gz}"
 clipPath="${AUDIO_CLIP_PATH:-}"
 
-# Calculate num_buffers based on duration
-# Formula: num_buffers = (sample_rate * duration) / samples_per_buffer
-# Example: (44100 * 10) / 1024 = 430 buffers for 10 seconds
-NUM_BUFFERS=$(( (SAMPLE_RATE * duration) / SAMPLES_PER_BUFFER ))
-
 # Validate numeric parameters (only validate if explicitly set)
 for param in AUDIO_DURATION AUDIO_GST_DEBUG GST_DEBUG_LEVEL; do
   val=""
@@ -367,6 +382,11 @@ if [ -n "$testName" ]; then
   esac
 fi
 
+# Calculate num_buffers based on final duration value
+# Formula: num_buffers = (sample_rate * duration) / samples_per_buffer
+# Example: (44100 * 10) / 1024 = 430 buffers for 10 seconds
+NUM_BUFFERS=$(( (SAMPLE_RATE * duration) / SAMPLES_PER_BUFFER ))
+
 # -------------------- Pre-checks --------------------
 check_dependencies "gst-launch-1.0 gst-inspect-1.0 awk grep head sed tr stat find curl tar" >/dev/null 2>&1 || {
   log_skip "Missing required tools (gst-launch-1.0, gst-inspect-1.0, awk, grep, head, sed, tr, stat, find, curl, tar)"

Runner/utils/lib_gstreamer.sh

@@ -24,7 +24,7 @@ GSTLAUNCHFLAGS="${GSTLAUNCHFLAGS:--e -v -m}"
 # gstreamer_shared_artifact_dir <env_var_name> <shared_subdir> <local_subdir> <script_dir> <outdir>
 # Generic function to get shared artifact directory for any test type.
 # Priority:
-# 1. Environment variable if explicitly provided (e.g., VIDEO_SHARED_ENCODE_DIR, AUDIO_SHARED_ENCODE_DIR)
+# 1. Environment variable if explicitly provided (e.g., VIDEO_SHARED_ENCODE_DIR, AUDIO_SHARED_RECORDED_DIR)
 # 2. A job-shared path derived from the common LAVA prefix before /tests/
 # 3. Fallback to <outdir>/<local_subdir> for local/manual runs
 #
@@ -37,7 +37,7 @@ GSTLAUNCHFLAGS="${GSTLAUNCHFLAGS:--e -v -m}"
 #
 # Example usage:
 #   gstreamer_shared_artifact_dir "VIDEO_SHARED_ENCODE_DIR" "video-encode-decode" "encoded" "$SCRIPT_DIR" "$OUTDIR"
-#   gstreamer_shared_artifact_dir "AUDIO_SHARED_ENCODE_DIR" "audio-record-playback" "recorded" "$SCRIPT_DIR" "$OUTDIR"
+#   gstreamer_shared_artifact_dir "AUDIO_SHARED_RECORDED_DIR" "audio-record-playback" "recorded" "$SCRIPT_DIR" "$OUTDIR"
 gstreamer_shared_artifact_dir() {
     env_var_name="$1"
     shared_subdir="$2"
@@ -82,14 +82,14 @@ gstreamer_shared_encoded_dir() {
 # gstreamer_shared_recorded_dir <script_dir> <outdir>
 # Prints a directory path to use for recorded audio artifacts.
 # Priority:
-# 1. AUDIO_SHARED_ENCODE_DIR if explicitly provided
+# 1. AUDIO_SHARED_RECORDED_DIR if explicitly provided
 # 2. A job-shared path derived from the common LAVA prefix before /tests/
 # 3. Fallback to <outdir>/recorded for local/manual runs
 gstreamer_shared_recorded_dir() {
     script_dir="$1"
     outdir="$2"
 
-    gstreamer_shared_artifact_dir "AUDIO_SHARED_ENCODE_DIR" "audio-record-playback" "recorded" "$script_dir" "$outdir"
+    gstreamer_shared_artifact_dir "AUDIO_SHARED_RECORDED_DIR" "audio-record-playback" "recorded" "$script_dir" "$outdir"
 }
 # -------------------- Element check --------------------
 has_element() {