[Doc] Document LossModule and collector weight sharing - #4231
Open
YeonwooSung wants to merge 2 commits into
Open
[Doc] Document LossModule and collector weight sharing#4231YeonwooSung wants to merge 2 commits into
YeonwooSung wants to merge 2 commits into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/4231
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit dac9946 with merge base 1d3de3d ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Describe synchronization in terms of shared parameter storage. Same-device arguments may preserve storage, while worker-created, copied, and remote policies require a configured update path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Document how
LossModuleand collectors share policy weights, and whencollector.update_policy_weights_()is actually required.The objectives landing page (and the DDPG tutorial) said losses "contain a copy of the trainable parameters". That wording made it look like an optimizer step on the loss would not update the original module, and that a collector always needed an explicit sync. Maintainer answers on #3032 already settled the semantics; this PR writes them down.
LossModuledoes not copy it. The same parameters are used in-place; optimizer steps on the loss update the original module.update_policy_weights_()is required whenpolicy_deviceordeviceremaps the policy (a.to(...)copy is made). Calling it anyway is good practice but not load-bearing unless devices were remapped.Cross-links:
LossModule/ objectives landing page ↔ collectors weight-sync page.Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213if this solves the issue #15213close #3032
Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!