-
Notifications
You must be signed in to change notification settings - Fork 806
Change runner environment for Android emulator #16614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The runner change from
linux.24xl.spr-metal(bare-metal with KVM support) to8-core-ubuntu(shared virtualized runner) will significantly impact Android emulator performance. The emulator is configured to use 6 cores and 16GB RAM (lines 122-123), and the comment at line 110 mentions 10-minute cold boot times. On a shared virtualized runner without KVM acceleration, emulator boot times and test execution could be substantially longer, potentially causing timeouts. Consider: 1) reducing theemulator-boot-timeout(line 129) if testing shows improved performance, or increasing it if timeouts occur, 2) verifying the shared runner has sufficient memory for the 16GB RAM allocation, and 3) monitoring job duration after this change.