-
Notifications
You must be signed in to change notification settings - Fork 800
Change runner environment for Android emulator #16614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16614
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 8b7ac89 with merge base a0ba28e ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR changes the GitHub Actions runner environment for the Android emulator job from linux.24xl.spr-metal to 8-core-ubuntu.
Changes:
- Updated the runner configuration for the
run-emulatorjob
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # NB: Use metal install for KVM support to run the emulator faster | ||
| runs-on: linux.24xl.spr-metal | ||
| # NB: This job runs on the shared 8-core-ubuntu runner; KVM / bare-metal assumptions no longer apply | ||
| runs-on: 8-core-ubuntu |
Copilot
AI
Jan 15, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The runner change from linux.24xl.spr-metal (bare-metal with KVM support) to 8-core-ubuntu (shared virtualized runner) will significantly impact Android emulator performance. The emulator is configured to use 6 cores and 16GB RAM (lines 122-123), and the comment at line 110 mentions 10-minute cold boot times. On a shared virtualized runner without KVM acceleration, emulator boot times and test execution could be substantially longer, potentially causing timeouts. Consider: 1) reducing the emulator-boot-timeout (line 129) if testing shows improved performance, or increasing it if timeouts occur, 2) verifying the shared runner has sufficient memory for the 16GB RAM allocation, and 3) monitoring job duration after this change.
No description provided.