Skip to content

Conversation

@kirklandsign
Copy link
Contributor

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 15, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16614

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 8b7ac89 with merge base a0ba28e (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 15, 2026
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@kirklandsign kirklandsign marked this pull request as ready for review January 15, 2026 03:49
Copilot AI review requested due to automatic review settings January 15, 2026 03:49
@kirklandsign kirklandsign requested a review from lucylq January 15, 2026 03:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes the GitHub Actions runner environment for the Android emulator job from linux.24xl.spr-metal to 8-core-ubuntu.

Changes:

  • Updated the runner configuration for the run-emulator job

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 15, 2026 06:16
@kirklandsign kirklandsign mentioned this pull request Jan 15, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

# NB: Use metal install for KVM support to run the emulator faster
runs-on: linux.24xl.spr-metal
# NB: This job runs on the shared 8-core-ubuntu runner; KVM / bare-metal assumptions no longer apply
runs-on: 8-core-ubuntu
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The runner change from linux.24xl.spr-metal (bare-metal with KVM support) to 8-core-ubuntu (shared virtualized runner) will significantly impact Android emulator performance. The emulator is configured to use 6 cores and 16GB RAM (lines 122-123), and the comment at line 110 mentions 10-minute cold boot times. On a shared virtualized runner without KVM acceleration, emulator boot times and test execution could be substantially longer, potentially causing timeouts. Consider: 1) reducing the emulator-boot-timeout (line 129) if testing shows improved performance, or increasing it if timeouts occur, 2) verifying the shared runner has sufficient memory for the 16GB RAM allocation, and 3) monitoring job duration after this change.

Copilot uses AI. Check for mistakes.
@kirklandsign kirklandsign merged commit 5fc4312 into main Jan 15, 2026
257 of 261 checks passed
@kirklandsign kirklandsign deleted the kirklandsign-patch-1 branch January 15, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants