Skip to content

Fix test patch targets for lazy-imported similar_talks #4570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrick91 merged 1 commit into from
Feb 9, 2026
Merged

Fix test patch targets for lazy-imported similar_talks #4570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions backend/reviews/tests/test_recap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@ def test_recap_view_returns_correct_context(rf):


def test_recap_view_does_not_call_ml_functions(rf, mocker):
mock_similar = mocker.patch("reviews.admin.compute_similar_talks")
mock_clusters = mocker.patch("reviews.admin.compute_topic_clusters")
mock_similar = mocker.patch("reviews.similar_talks.compute_similar_talks")
mock_clusters = mocker.patch("reviews.similar_talks.compute_topic_clusters")

user, conference, review_session, submissions = _create_recap_setup()

Expand Down Expand Up @@ -187,14 +187,14 @@ def test_compute_analysis_view_returns_submissions_and_clusters(rf, mocker):
sub1, sub2 = submissions

mocker.patch(
"reviews.admin.compute_similar_talks",
"reviews.similar_talks.compute_similar_talks",
return_value={
sub1.id: [{"id": sub2.id, "title": str(sub2.title), "similarity": 75.0}],
sub2.id: [],
},
)
mocker.patch(
"reviews.admin.compute_topic_clusters",
"reviews.similar_talks.compute_topic_clusters",
return_value={
"topics": [{"name": "ML", "count": 2, "keywords": ["ml"], "submissions": []}],
"outliers": [],
Expand Down Expand Up @@ -236,11 +236,11 @@ def test_compute_analysis_view_returns_submissions_and_clusters(rf, mocker):

def test_compute_analysis_view_passes_recompute_flag(rf, mocker):
mock_similar = mocker.patch(
"reviews.admin.compute_similar_talks",
"reviews.similar_talks.compute_similar_talks",
return_value={},
)
mock_clusters = mocker.patch(
"reviews.admin.compute_topic_clusters",
"reviews.similar_talks.compute_topic_clusters",
return_value={"topics": [], "outliers": [], "submission_topics": {}},
)

Expand All @@ -261,11 +261,11 @@ def test_compute_analysis_view_passes_recompute_flag(rf, mocker):

def test_compute_analysis_view_no_recompute_by_default(rf, mocker):
mock_similar = mocker.patch(
"reviews.admin.compute_similar_talks",
"reviews.similar_talks.compute_similar_talks",
return_value={},
)
mock_clusters = mocker.patch(
"reviews.admin.compute_topic_clusters",
"reviews.similar_talks.compute_topic_clusters",
return_value={"topics": [], "outliers": [], "submission_topics": {}},
)

Expand Down
Loading