Fix test patch targets for lazy-imported similar_talks#4570
Merged
Conversation
Update mocker.patch targets from reviews.admin to reviews.similar_talks since the import was moved inline.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Fix correctly updates test patch targets after PR #4569 moved the imports inline. The mock patches now target reviews.similar_talks module directly instead of reviews.admin, which is correct since the functions are imported inside the view function at runtime. No issues found. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4570 +/- ##
=======================================
Coverage 92.50% 92.50%
=======================================
Files 355 355
Lines 10658 10658
Branches 812 812
=======================================
Hits 9859 9859
Misses 687 687
Partials 112 112 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reviews.admin.compute_similar_talkstoreviews.similar_talks.compute_similar_talks(same forcompute_topic_clusters)reviews.adminTest plan