Skip to content

Fix test patch targets for lazy-imported similar_talks#4570

Merged
patrick91 merged 1 commit intomainfrom
fix/lazy-import-test-patches
Feb 9, 2026
Merged

Fix test patch targets for lazy-imported similar_talks#4570
patrick91 merged 1 commit intomainfrom
fix/lazy-import-test-patches

Conversation

@patrick91
Copy link
Member

Summary

  • Update mocker.patch targets in test_recap.py from reviews.admin.compute_similar_talks to reviews.similar_talks.compute_similar_talks (same for compute_topic_clusters)
  • Needed because Lazy-import similar_talks to fix Gunicorn worker OOM on startup #4569 moved the import inline, so the functions are no longer module-level attributes of reviews.admin

Test plan

  • CI passes

Update mocker.patch targets from reviews.admin to
reviews.similar_talks since the import was moved inline.
@vercel
Copy link

vercel bot commented Feb 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pycon Ready Ready Preview Feb 9, 2026 2:31pm

@claude
Copy link
Contributor

claude bot commented Feb 9, 2026

Fix correctly updates test patch targets after PR #4569 moved the imports inline. The mock patches now target reviews.similar_talks module directly instead of reviews.admin, which is correct since the functions are imported inside the view function at runtime.

No issues found.

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.50%. Comparing base (5fd9f3e) to head (afccac8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4570   +/-   ##
=======================================
  Coverage   92.50%   92.50%           
=======================================
  Files         355      355           
  Lines       10658    10658           
  Branches      812      812           
=======================================
  Hits         9859     9859           
  Misses        687      687           
  Partials      112      112           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@patrick91 patrick91 merged commit 4883f6c into main Feb 9, 2026
8 checks passed
@patrick91 patrick91 deleted the fix/lazy-import-test-patches branch February 9, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments